Save to Pocket icon issue with twitter page navigation.
Categories
(Firefox :: Pocket, defect, P5)
Tracking
()
People
(Reporter: thecount, Assigned: thecount)
Details
If you save a tweet to Pocket, then navigate to another page in twitter, the Pocket icon stays red and should not.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
I was able to do a bit of investigating for this while doing another bug.
When the tab changes, Pocket looks at the browser's innerWindowID, and compares it with cached innerHwindowIDs we saved with Pocket. For some reason the twitter navigation doesn't have new innerWindowIDs while you navigate from within Twitter. They might be doing their own history manipulation that for some reason isn't changing the innerWindowIDs. This means while navigating inside twitter, the innerWindowID doesn't change, and thus it always matches the one you saved on, thinking it's still Pocketed.
My personal opinion on this is innerWindowIDs are kinda confusing an abstract for this anyway, and why not use the url as the identifier? Is it too long, unique characters issues, or privacy reasons? Pocket isn't pocketing innerWindowIDs, it's pocketing urls, so we should be matching against that too?
Description
•