1705394 - Consider splitting C++ Metric Type implementations out from their headers.

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

Every time I make an implementation-only change to any metric type's C++ implementation, it seems like I have to rebuild the world. Rebuilding a lot makes sense since the C++ impls are in header files (for laziness reasons, mostly), but why the world?

Maybe since we instrumented IPC code every change to those headers requires changing anything that knows anything about PContent?

Anyhoo, we could totally put this all in the .cpp files we already have.

I must say I like the separation of C++ impl from JS impl most of the time. Maybe we consider _js.cpp and _cpp.cpp files both? They're namespaced differently (C++ is in impl) and are quite short without their comments, so it's not necessary and might not be desirable.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1705394 - Split FOG MLA impls from their headers r?TravisLong!

Not doing Event because generic template impls must be in headers.

Basically a machine translation, but you might notice I had to inline
some static functions in the generated header-only map files?
That's because otherwise we'll get complaints from the build system that
those functions are unused in the files where they're unused.

The alternative would be to split those map files into headers and impls.
Which is more work than is needed for this bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5884935374cf
Split FOG MLA impls from their headers r=TravisLong

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5884935374cf