1705420 - Report the version of the application being tested in our perfherder data

Status: RESOLVED DUPLICATE of bug 1828635

(Testing :: mozperftest, task, P3)

Description

[Greg Mierzwinski [:sparky]]

Our perfherder data in mozperftest contains the application being tested but it doesn't gather the version being used: https://searchfox.org/mozilla-central/source/python/mozperftest/mozperftest/metrics/perfherder.py#109

Comment 1

[Kimberly Sereduck :kimberlythegeek]

Attachment: Bug 1705420: Report the version of the application being tested in our perfherder data;r=#perftest

implementing get_browser_meta for mozperftest

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b533ae02d367
Report the version of the application being tested in our perfherder data r=perftest-reviewers,sparky

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b533ae02d367

Comment 4

[Kimberly Sereduck :kimberlythegeek]

Attachment: WIP: Bug 1705420: Report the version of the application being tested in our perfherder data

implementing get_browser_meta for mozperftest

Comment 5

[Kimberly Sereduck :kimberlythegeek]

Attachment: WIP: Bug 1705420: Report the version of the application being tested in our perfherder data;r=perftest-reviewers

Comment 6

[Kimberly Sereduck :kimberlythegeek]

Attachment: WIP: Bug 1705420: Report the version of the application being tested in our perfherder data;r=perftest-reviewers

Depends on D119881

Comment 7

[Kimberly Sereduck :kimberlythegeek]

Attachment: Bug 1705420: Report the version of the application being tested in our perfherder data;r=perftest-reviewers

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33c7fac3a855
Backed out changeset b533ae02d367 as requested by Kimberly. CLOSED TREE

Comment 9

[Kimberly Sereduck :kimberlythegeek]

Attachment: Bug 1705420: Report the version of the application being tested in our perfherder data;r=#perftest

Comment 10

[Kimberly Sereduck :kimberlythegeek]

Currently blocked until able to test on a local android device. In the process of trying to set up my current device or requesting a new one

Comment 11

[Kimberly Sereduck :kimberlythegeek]

I have been to (I think) correctly get application version for android, but I am unable to verify this because of errors when running in CI

the task completes successfully, but there is an error decoding a unicode character in the logs:
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=304e7658ffe75adb526d8766e722b2887cf2256e
https://firefox-ci-tc.services.mozilla.com/tasks/cXxPGFf5QL-_zJVWCYpITA/runs/1/logs/public/logs/live.log#L652

I have run the unit test for parsing logcat both locally and in CI, and modified the test file to include the unicode character which was called the test to fail, but the unit test passes without failure.

Dave Hunt suggested this could be related to python version when running a unit test versus the actual android devices, or maybe default encoding that has been set.

The "ordinal not in range" error is being thrown here: https://searchfox.org/mozilla-central/source/python/mozperftest/mozperftest/metrics/notebook/transformer.py#94-103

:ahal, do you have any insight on why this unicode error is being thrown on android devices, but not locally or in the unit tests?

Comment 12

[Kimberly Sereduck :kimberlythegeek]

here is a passing unit test running against a test file containing unicode: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=18f3cde67b959c7210c46c246e10d49d37f6e778

Comment 13

[Andrew Halberstadt [:ahal]]

No special insight, but decoding errors like that can happen when there's a character the encoding doesn't support. So it's likely just that the logcat happens to contain only 'ascii' characters when run locally or against desktop CI, but something in the Android suites is logging a unicode character. I don't seem to see a traceback in there, so I'm not sure where the exception is being thrown, but I'd guess when you obtain the logcat it's being returned as a byte-string, then you're trying to manipulate it some way that is implicitly decoding it with the ascii encoding.

To fix you might need to do something like logcat_output.decode("utf-8") first. Or if you are using subprocess to obtain it, you can pass universal_newlines=True.