1705440 - Clean up all the modal prefs and remove / delete old implementations (contentPromptSubDialog / tabPromptSubDialog / tabmodalprompt) after proton ships

Status: RESOLVED FIXED

(Toolkit :: Content Prompts, task, P3)

Description

[:Gijs (he/him)]

Once we ship, we should remove the prompts.{tab,content,window}PromptSubDialog prefs, and the tabmodalprompt implementation which will be unused, and clean up all the remaining tests specific to the old implementation(s).

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)

the tabmodalprompt implementation which will be unused, and clean up all the remaining tests specific to the old implementation(s).

It looks like at least from bug 1702059 we're still using the tabmodalprompt implementation in about:addons, and we'd have to either fix that or keep the old stuff around, I guess... I don't know off-hand how hard it would be to move those consumers over to the new framework.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Maybe of interest to you, Greg.

Comment 4

[:Gijs (he/him)]

It took me too long to find this so adding some verbiage to make this bug easier to get back to.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1705440 - remove old modal prompt implementation, r?mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89f62e190e69
remove old modal prompt implementation, r=mconley,webdriver-reviewers,extension-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,whimboo,rpl

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_ext_sidebarAction_contextMenu.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c592c8d9a28f105f80dd66f1bd093092b086f0ad

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=89f62e190e69ddb95685488010b5807b31491168&selectedTaskRun=XFhXazB2SEiTQx-ketoxOA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=451442065&repo=autoland&lineNumber=5246

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f817dd8e7be
remove old modal prompt implementation, r=mconley,webdriver-reviewers,extension-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,whimboo,rpl

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0f817dd8e7be