1705484 - Remove OS.* from IOUtils unit tests

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Description

[Beth Rennie [:beth] (she/her)]

OS.File etc were used as a stopgap in IOUtils tests before IOUtils was finished. We should replace usages of OS.File there with IOUtils.

The only exception is test_ioutils_read_write.html, which is testing compatibility with IOUtils and OS.File compression

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1705484 - Remove OS.* from most IOUtils tests r?gijs,emalysz

Depends on D113450

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58e0c5dca806
Remove OS.* from most IOUtils tests r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_ioutils_copy_move.html

backout: https://hg.mozilla.org/integration/autoland/rev/a2888594a2676480b7d622117fba394e43ca4d15

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=58e0c5dca806f5a0efbf5c5cf6545a70750f01bb&group_state=expanded&selectedTaskRun=ch_s1SsNQkSW9aCmOwyPKA.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=338341583&repo=autoland&lineNumber=2373

[task 2021-04-30T18:23:57.136Z] 18:23:57 INFO - TEST-PASS | dom/system/tests/ioutils/test_ioutils_copy_move.html | Removed temporary file: /tmp/test_move_failure_src.tmp.d
[task 2021-04-30T18:23:57.137Z] 18:23:57 INFO - add_task | Leaving test test_move_failures
[task 2021-04-30T18:23:57.138Z] 18:23:57 INFO - add_task | Entering test test_copy
[task 2021-04-30T18:23:57.138Z] 18:23:57 INFO - Buffered messages finished
[task 2021-04-30T18:23:57.140Z] 18:23:57 INFO - TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_copy_move.html | OperationError: PathUtils.join: Could not initialize path: NS_ERROR_FILE_UNRECOGNIZED_PATH - Should not throw any errors
[task 2021-04-30T18:23:57.140Z] 18:23:57 INFO - test_copy@chrome://mochitests/content/chrome/dom/system/tests/ioutils/test_ioutils_copy_move.html:196:37
[task 2021-04-30T18:23:57.140Z] 18:23:57 INFO - nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2250:34
[task 2021-04-30T18:23:57.141Z] 18:23:57 INFO - GECKO(1545) | MEMORY STAT | vsize 3084MB | residentFast 431MB | heapAllocated 193MB
[task 2021-04-30T18:23:57.142Z] 18:23:57 INFO - TEST-OK | dom/system/tests/ioutils/test_ioutils_copy_move.html | took 123ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2bf2c83f0bb
Remove OS.* from most IOUtils tests r=Gijs

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset a2bf2c83f0bb (Bug 1705484) for causing mochitest failures in test_ioutils_copy_move.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/a3b9124e2dd9989f8006b11a3b7ef6a1d076ab1d
Push with failures, failure log.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc7949357a91
Remove OS.* from most IOUtils tests r=Gijs

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dc7949357a91