1705506 - Proton new user onboarding background should fallback to solid background color when fail to load bkg image

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Noticed in Nightly , failed to load avif was causing background to not use radial gradient set below

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/aboutwelcome.scss#533

Scope of this bug is to gracefully fallback to use gradient colors when bkg image doesn't load

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1705506 - Add background color to handle failure to load background image

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15dd8c3891fb
Add background color to handle failure to load background image r=emcminn

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/15dd8c3891fb

Comment 4

[Punam Dahiya [:pdahiya]]

Comment on attachment 9217306 [details]
Bug 1705506 - Add background color to handle failure to load background image

Beta/Release Uplift Approval Request

• User impact if declined: Failure to load background image will show light background making content unreadable
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) Open about:welcome

2. Right Click -> inspect -> search HTML for 'proton-bkg.webp'
3. change "chrome://activity-stream/content/data/content/assets/proton-bkg.webp" URL in background-image to any test url to simulate image load failure

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch changing background-color in CSS
• String changes made/needed: None

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the background of the Onboarding page fallback to a dark color gradient and all the page elements are fully visible.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210427221830) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9217306 [details]
Bug 1705506 - Add background color to handle failure to load background image

Approved for 89 beta 6, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1eddd21e7c49

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the background of the Onboarding page fallback to a dark color gradient and all the page elements are fully visible.

Verified using the latest Firefox Beta (89.0b7 Build ID - 20210502185943) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.