Closed Bug 1705551 Opened 3 years ago Closed 2 years ago

Vertical spacing in new permission prompts for webrtc feels a little off

Categories

(Firefox :: Site Permissions, defect, P2)

Product:
Firefox
Component:
Site Permissions
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: glandium, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers] [priority:2a])

Attachments

(2 files)

Screenshot
44.17 KB, image/png
Details
Bug 1705551 - Remove block margins from menulists in popup notifications since the popupnotificationcotnent already has margin-top.
48 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot —

Going off the attached screenshot of a screenshot in a presentation:

The vertical spacing between the camera and the mic is larger than the vertical spacing between the mic and the "Remember the decision", and something feels off.

Blocks: proton-door-hangers
Severity: -- → S4
Type: enhancement → defect
Priority: -- → P2
Whiteboard: [proton-door-hangers] [priority:2a]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da0500816698
Remove block margins from menulists in popup notifications since the popupnotificationcotnent already has margin-top. r=emalysz

https://hg.mozilla.org/mozilla-central/rev/da0500816698

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Flags: qe-verify+

Reproduced the issue on affected 89.0a1 on MacOS 10.15. Verified-fixed on latest Firefox Nightly 91.0a1 and Beta 90.0b4 on MacOS 10.15.

Status: RESOLVED → VERIFIED
status-firefox90: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.