1705562 - The Address Bar and Search Bar box-shadow is cut

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak]]

Due to recent changes to the toolbar padding now the urlbar and searchbar box-shadow is cut, that's quite visible in Light.
I was trying a box-shadow: 0 1px 3px rgba(0, 0, 0, 0.23); as an alternative, there's no spec for this toolbar size, we may have to test and get an ok from UX.

Comment 1

[Marco Bonardo [:mak]]

I'l make a try build to submit to PM/UX and check if the new shadow is ok.

Comment 2

[Marco Bonardo [:mak]]

I attached the builds to Jira Spike https://jira.mozilla.com/browse/FIDEFE-1304

Comment 3

[Marco Bonardo [:mak]]

Attachment: Screenshot (245)_LI.jpg

Here you can see the cut shadow

Comment 4

[Romain Testard [:RT]]

I reviewed the try build and am OK with the proposed change.

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1705562 - Reduce the Address Bar and Search Bar box-shadows so they are not cut. r=harry

Due to recent reduction of padding on the toolbars, the current shadow doesn't fit anymore.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5de09321997
Reduce the Address Bar and Search Bar box-shadows so they are not cut. r=harry,desktop-theme-reviewers

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d5de09321997

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 9218761 [details]
Bug 1705562 - Reduce the Address Bar and Search Bar box-shadows so they are not cut. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: Part of MR1 design
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check the shadow around urlbar and searchbar is not cut anymore
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial css box-shadow change
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9218761 [details]
Bug 1705562 - Reduce the Address Bar and Search Bar box-shadows so they are not cut. r=harry

Approved for 89 beta 6, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1df0218487d5

Comment 11

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7