1705572 - Search Bar has wrong background in overflow menu when light theme is enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Peter deHaan [:pdehaan]]

This comment is copy/pasted from a community issue filed during the Foxfooding program.

---

Firefox Version: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
Window Size (inner width and height): 1366x620

Steps to Reproduce

1. Go to Hamburger menu > More Tools > Customize Toolbar
2. Enable the Light theme
3. Now, drag the Search item to the OVERFLOW menu

Expected Behavior

The search - item should be watchable perfectly

Actual Behavior

We see that the search menu is not watchable in the light theme

Comment 1

[Romain Testard [:RT]]

Attachment: search.png

I cannot reproduce on Win10, can you please provide a screenshot and detail on the OS used and what OS theme is in use?

Comment 2

[Marco Bonardo [:mak]]

Attachment: Screenshot (249)_LI.jpg

I can reproduce, you must move the search bar into the OVERFLOW toolbar menu. It looks like the background of the search field is wrong.

This is probably a not-so-common layout, but would be nice to fix it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1705572 - Fix search Bar colors when it's in the toolbar overflow menu. r=harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2ab512468e9
Fix search Bar colors when it's in the toolbar overflow menu. r=harry,desktop-theme-reviewers

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f2ab512468e9

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 9219249 [details]
Bug 1705572 - Fix search Bar colors when it's in the toolbar overflow menu. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: Part of MR1 design
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The search bar should remain distinguishable across toolbars and overflow.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're extending existing and well tested style of the search bar to more customize locations (toolbars)
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9219249 [details]
Bug 1705572 - Fix search Bar colors when it's in the toolbar overflow menu. r=harry

Low risk CSS patch, approved for 89 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e7246869da5

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 89.0a1 (2021-04-14), on macOS 10.13.6.
I can confirm this issue is fixed; I verified using Fx 90.0a1(2021-05-05) and Fx 89.0b8 on macOS 10.13.6, Ubuntu 20.04 LTS and Windows 10 x64.