1705659 - Rewrite authentication code with Tokenizer

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Use Tokenizer in ParseRealm r=#necko

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Use Tokenizer in nsHttpChannelAuthProvider::GetCredentials r=#necko

• Passes challenges as const nsACString&
• Uses Tokenizer to parse input
• Uses nsHttpDigestAuth::ParseChallenge instead of duplicating code
• Sorts challenges by algorithm
• Note: bits of code that use a FlatCString and raw char pointers are fixed
  in a following patch in this stack

Depends on D112594

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Modernize test_authentication.js r=#necko

Depends on D112595

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Make GetAuthenticator work with nsACString r=#necko

Depends on D112596

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=#necko

Depends on D112597

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Use a nsTArray<CString> instead of custom linked list r=#necko

Depends on D112598

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - nsHttpNTLMAuth::GenerateCredentials should avoid raw strings r=#necko

Depends on D112599

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Make nsHttpDigestAuth::ParseChallenge work with a nsACString without extra copy r=#necko

Depends on D112601

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=#necko

Depends on D112602

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Make Host() and ProxyHost() return const nsCString& r=#necko

Depends on D112603

Comment 11

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Static-analysis check auto fix for auth code r=#necko

Depends on D112604

Comment 12

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Make DigestLength a function r=#necko

Depends on D112596

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705659 - Use nsACString& in ParseRealm and GetCredentialsForChallenge r=#necko

• The use of PromiseFlatCString is temporary. It is removed in the next patches in the stack.

Depends on D112911

Comment 14

[Phabricator Automation]

Comment on attachment 9216792 [details]
Bug 1705659 - Use Tokenizer in ParseRealm r=#necko

Revision D112594 was moved to bug 669675. Setting attachment 9216792 [details] to obsolete.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05492b6578a9
Modernize test_authentication.js r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/eab68e8bea29
Make DigestLength a function r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8af29f96ac77
Use nsACString& in ParseRealm and GetCredentialsForChallenge r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/36eff14cf2ea
Use Tokenizer in nsHttpChannelAuthProvider::GetCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3af362aa2b25
Make nsHttpDigestAuth::ParseChallenge work with a nsACString without extra copy r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/18d3a604336a
Make GetAuthenticator work with nsACString r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/4337214c8846
Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5c13ec25cc2e
Use a nsTArray<CString> instead of custom linked list r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c808bf01dfe8
nsHttpNTLMAuth::GenerateCredentials should avoid raw strings r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/897868e22c81
Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/ff4348e0a307
Make Host() and ProxyHost() return const nsCString& r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/2aee05c2d6f3
Static-analysis check auto fix for auth code r=necko-reviewers,dragana

Comment 16

[Alexandru Michis [:malexandru]]

Backed out 14 changesets (Bug 1705659, Bug 472823, Bug 669675) for causing bustages in nsHttpChannelAuthProvider.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/a9431e068bcd2dc86778d9b12bc7775850e2736b
Push with failures, failure log.

(Update): Also caused mochitest plain failures.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6b51bc167ac
Modernize test_authentication.js r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5449d9e08034
Make DigestLength a function r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c977551bad6e
Use nsACString& in ParseRealm and GetCredentialsForChallenge r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/2f0aacbd42b1
Use Tokenizer in nsHttpChannelAuthProvider::GetCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/0ea348abee78
Make nsHttpDigestAuth::ParseChallenge work with a nsACString without extra copy r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/de990e6c944d
Make GetAuthenticator work with nsACString r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/e688986c7011
Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/a179695a56c9
Use a nsTArray<CString> instead of custom linked list r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3c9556a8df55
nsHttpNTLMAuth::GenerateCredentials should avoid raw strings r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/46e559f45338
Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/361c177ed131
Make Host() and ProxyHost() return const nsCString& r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/adad38c05584
Static-analysis check auto fix for auth code r=necko-reviewers,dragana

Comment 18

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b6b51bc167ac
https://hg.mozilla.org/mozilla-central/rev/5449d9e08034
https://hg.mozilla.org/mozilla-central/rev/c977551bad6e
https://hg.mozilla.org/mozilla-central/rev/2f0aacbd42b1
https://hg.mozilla.org/mozilla-central/rev/0ea348abee78
https://hg.mozilla.org/mozilla-central/rev/de990e6c944d
https://hg.mozilla.org/mozilla-central/rev/e688986c7011
https://hg.mozilla.org/mozilla-central/rev/a179695a56c9
https://hg.mozilla.org/mozilla-central/rev/3c9556a8df55
https://hg.mozilla.org/mozilla-central/rev/46e559f45338
https://hg.mozilla.org/mozilla-central/rev/361c177ed131
https://hg.mozilla.org/mozilla-central/rev/adad38c05584

Comment 19

[Cristian Brindusan [:cbrindusan]]

Backed out 14 changesets (Bug 1705659, Bug 472823, Bug 669675) as requested by valentin for causing regressions.
https://hg.mozilla.org/integration/autoland/rev/4207821cb4e016141be3c4b331f1ede47c90c0b7

Comment 20

[Julien Cristau [:jcristau]]

beta backout: https://hg.mozilla.org/releases/mozilla-beta/rev/0830f6eb4b5e3a19d2e5f49213e8b531909443f2

Comment 21

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/4207821cb4e0

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/090b4ff09c66
Modernize test_authentication.js r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/76462198a0e3
Make DigestLength a function r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/94897e7cc6e8
Use nsACString& in ParseRealm and GetCredentialsForChallenge r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/d1d299ee9271
Use Tokenizer in nsHttpChannelAuthProvider::GetCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3245e43a3ef8
Make nsHttpDigestAuth::ParseChallenge work with a nsACString without extra copy r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/378d8f794bde
Make GetAuthenticator work with nsACString r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/da10f609bb94
Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/36f63a708615
Use a nsTArray<CString> instead of custom linked list r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/7c3b36a07eef
nsHttpNTLMAuth::GenerateCredentials should avoid raw strings r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/0b63e24e8d16
Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/2c981fa45bb8
Make Host() and ProxyHost() return const nsCString& r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c0d6eff2103b
Static-analysis check auto fix for auth code r=necko-reviewers,dragana

Comment 23

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/090b4ff09c66
https://hg.mozilla.org/mozilla-central/rev/76462198a0e3
https://hg.mozilla.org/mozilla-central/rev/94897e7cc6e8
https://hg.mozilla.org/mozilla-central/rev/d1d299ee9271
https://hg.mozilla.org/mozilla-central/rev/3245e43a3ef8
https://hg.mozilla.org/mozilla-central/rev/378d8f794bde
https://hg.mozilla.org/mozilla-central/rev/da10f609bb94
https://hg.mozilla.org/mozilla-central/rev/36f63a708615
https://hg.mozilla.org/mozilla-central/rev/7c3b36a07eef
https://hg.mozilla.org/mozilla-central/rev/0b63e24e8d16
https://hg.mozilla.org/mozilla-central/rev/2c981fa45bb8
https://hg.mozilla.org/mozilla-central/rev/c0d6eff2103b