1705661 - Pinned tab with black favicon is hard to read

Status: NEW

(Firefox :: Theme, defect, P3)

Description

[:gerard-majax]

Attachment: pinned-black.png

When using pinned tabs with a website that has a lack favicon (e.g., GitHub) results in a tab that is mostly impossible to read when using both System and Dark theme on Linux.

From testing, it looks like this repros with Dark theme mostly everywhere.

Comment 1

[:gerard-majax]

FTR, even switching to "Dark theme" of firefox and reloading the GitHub tab does not change anything.

Comment 2

[Sören Hentzschel]

How exactly is this related to Proton or pinned tabs? This was already the case with the old design and pinned tabs don't use different favicons than regular tabs.

Comment 3

[:gerard-majax]

(In reply to Sören Hentzschel from comment #2)

How exactly is this related to Proton or pinned tabs? This was already the case with the old design and pinned tabs don't use different favicons than regular tabs.

I was using "Container Theme" before, which I disabled for Proton, so I was not aware it was broken before. But since there is Proton work ongoing, it was my assumption it could be a good time to fix this as well? I have not filed that as a « regression » per se.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

I think the problem here is that although we are using a dark theme, this is not triggering the dark theme proposed by GitHub.
Edge with a dark theme displays GitHub with its dark theme which includes a dark mode compatible favicon. It seems that we only do that when dark mode is set at the OS level, not the browser level like Edge does.

Comment 5

[:gerard-majax]

Thanks for the input on Edge. Also, while this might not be directly a consequence of Proton, my rationale for filing now is that with Proton UX will get much scrutinity and small but painful defects like this one can attract bad feedback.