1705689 - Investigate UpdateSessionStoreFromTablistener calls that happen on a replaced browsing context

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[u608768]

We sometimes call this on a replaced browsing context, which might be a bug. We should maybe switch to fetching the browsing context by BrowserId, to ensure we have the latest context.

We'll only want to run the SessionHistory code in this function if context == context.top, which won't be immediately possible to check if we switch to using BrowserId (since GetTopByBrowserId by definition returns the top), so we might have to update callers to do the check or give us BrowserId=0 for subframes.

Comment 1

[u608768]

The condition added in bug 1705547 might actually be sufficient to check that we're not calling collect() on a replaced context, since we'll clear the context's SessionHistory reference when replacing. We'll likely still need to run the TabState.update() code for a replaced context, but :farre can confirm.

Comment 2

[u608768]

Per meeting with nika: we should avoid updating the cache for replaced contexts as well.

Comment 3

[u608768]

Anny did some maybe-related work in bug 1707138. This might be the root cause of that issue, so we should look into merging the changes when working on this.

Comment 4

[Andreas Farre [:farre]]

Attachment: Bug 1705689 - Don't update the tab state if the browsing context has been replaced. r=kashav!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29e77306d513
Don't update the tab state if the browsing context has been replaced. r=kashav

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/29e77306d513