1705733 - Replace threads.empty() check with CanUseExtraThreads()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

There are various places that will check threads.empty() in GlobalHelperThreadState.
for example,
CancelOffThreadIonCompileLocked
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/js/src/vm/HelperThreads.cpp#348

But Ion OffThread compilation is enabled when CanUseExtraThreads is true
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/js/src/jit/Ion.cpp#1934

So those threads.empty() should be changed to CanUseExtraThreads().

When we dispatch tasks to the external thread pool, we shouldn't check the threads(lock).empty(), as it is for internal threading inside Spidermonkey, so I'd like to get rid of those.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Bug 1705733 - Replace threads.empty() check with CanUseExtraThreads().

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a511889d7871
Replace threads.empty() check with CanUseExtraThreads(). r=jonco

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a511889d7871