Open Bug 1705785 Opened 4 years ago Updated 4 years ago

Consider removing the use of in-content/common.css from infobars and modals (SubDialog.jsm outside of preferences)

Categories

(Toolkit :: Themes, task, P3)

Desktop
All
task
Points:
5

Tracking

()

Tracking Status
firefox89 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

This was a suggestion from Dão in https://phabricator.services.mozilla.com/D112344 .

in-content/common.css would need replacing with browser-custom-colors.css, as well as ensuring appearance/border/margin/padding/shadow/outline/sizing related styling that is currently taken care of by common.css is still applied. We've done some of this already for checkboxes in e.g. bug 1697315, AIUI, but it's not clear to me how much work it would be to do it for all the other widgets we use. I am also not sure if that would mean we would ultimately stop using in-content/common.css entirely for those types of styles (ie remove the styles from there), relying purely on the toolkit/browser styling for those aspects of how components got styled. Either way, it would be an improvement if we could stop specifying one set of styles for in-content stuff, and another for browser chrome / dialogs.

Priority: -- → P3
Points: --- → 3
Points: 3 → 5
You need to log in before you can comment on or make changes to this bug.