1705821 - [widget.macos.respect-system-appearance] Regression: Broken Tooltip and Context Menu color when using Light Theme In System Dark Mode

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Mehmet]

Nightly 89.0a1 (2021-04-16) (64-Bit)
macOS 11.2.3

1.) Set widget.macos.respect-system-appearance to true
2.) Enable macOS System Dark Mode
3.) Select Light Theme in Nightly
4.) Hover over a tab

Actual: Dark Tooltip with dark Font

Expected: Dark Tooltip with white font (or white tooltip with dark font).

Same happens when using System Light Mode with Nightly Dark Theme.

Same happens with right click menus.

Comment 1

[Mehmet]

Right click menus are fixed when enabling widget.macos.native-context-menus. But the Tooltip issue still happens.

Comment 2

[Albert Scheiner [:alberts]]

Attachment: image.png

Could it already been fixed? I just tested it (macOS 11.2.3, dark OS theme, light FF theme, widget.macos.respect-system-appearance true) and it works fine for me.

Comment 3

[Albert Scheiner [:alberts]]

Attachment: context-menu.png

The context menu is dark, but as a user it doesn't surprise me that it follows the OS instead of the browser theme, but that might be just me.

Comment 4

[Mehmet]

Attachment: Tooltip Font Issue in System Dark Mode using FF Light Theme.png

I think it is okay using a dark context menu when using a light theme in system dark mode.

My problem is that the font on the tooltips is dark on dark tooltips when using a light theme in system dark mode.

I checked build 89.0a1 (2021-04-16) (64-Bit) and I still can reproduce. Here is a screencast.

Comment 5

[Mehmet]

Attachment: Tooltip Font Issue in System Light Mode using FF Dark Theme.png

Same when in System Light Mode and using FF Dark Theme. Then the font is light on a light tooltip.

Comment 6

[Mehmet]

Attachment: Bildschirmfoto 2021-04-19 um 19.50.14.png

Same happens on the Toolbar Icon Tooltips.

Comment 7

[Harry Twyford]

Setting firefox89: unaffected because it's unlikely widget.macos.respect-system-appearance will ship in 89. We can update the tracking if that changes.

Comment 8

[Mehmet]

Hi mbalfanz,

fyi: This is not only Dark Mode related. This happens when you are in System Light Mode and select the Dark Theme. And this also happens when you are in System Dark Mode and select the Light Theme. Thanks :)

Comment 9

[Martin Balfanz [:mbalfanz]]

Thanks for pointing this out :) The whiteboard marker is our way to organize work related to themes, so anything that's related to bug 1623686 or the widget.macos.respect-system-appearance pref falls into this category. I acknowledge that the wording might not be the ideal choice here.

Comment 10

[Mehmet]

(In reply to Martin Balfanz [:mbalfanz] from comment #9)

Thanks for pointing this out :) The whiteboard marker is our way to organize work related to themes, so anything that's related to bug 1623686 or the widget.macos.respect-system-appearance pref falls into this category. I acknowledge that the wording might not be the ideal choice here.

Ah, okay. Thanks for the clarification :)

Comment 11

[Stephen A Pohl [:spohl]]

This may already be covered by one of the other bugs blocking bug 1623686, but it can't hurt to track this separately until we've been able to verify a fix for it.

Comment 12

[Markus Stange [:mstange]]

Yeah, this is probably covered by bug 1703980.

Comment 13

[Harry Twyford]

This is fixed for me now that bug 1715145 has landed. Please let me know if you can still reproduce the issue.

Comment 14

[Mehmet]

(In reply to Harry Twyford [:harry] from comment #13)

This is fixed for me now that bug 1715145 has landed. Please let me know if you can still reproduce the issue.

Thanks :) Works for me now :)