Closed Bug 1705826 Opened 1 year ago Closed 1 year ago

Apply the overscroll effect to fixed content (non-WebRender)

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: botond, Assigned: botond)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-uplift])

Attachments

(2 files)

Splitting out the non-WebRender fix for bug 1704503 into this bug. Will use bug 1704503 to track the WR fix.

This is accomplished by the overscroll transform being part of the visual
component of the root content APZC's async transform.

We were already doing this right in AsyncPanZoomController (as of bug
1699868), but the call sites in AsyncCompositionManager needed to be
updated.

Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b729f0fb230
Apply the overscroll transform to content fixed to the root (non-WebRender). r=tnikkel
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

That is... very strange (but based on some retriggers the link between the failure and this patch does seem to be valid).

Flags: needinfo?(botond)

After some more Try pushes, I've narrowed down the test failure to being caused by the mere addition of a new reftest (and I've even removed all pref flips and reftest attributes to make sure there's nothing unusual about the reftest I'm adding that could be causing problems), which causes a re-chunking of reftests on the affected platform.

  • Here is a Try push of a recent autoland tip. Note the affected test, layout/reftests/text-decoration/skip-ink-multiline-position.html, is in the R1 chunk of Windows 7 opt, and it's passing consistently.
  • Here is a Try push of the same autoland revision + my added (very boring) reftest. Note that skip-ink-multiline-position.html has now moved to the R2 chunk of Windows 7 opt, and now it's failing consistently.

Jonathan, do you have a suggestion for what to do about this? Should I disable the offending test (skip-ink-multiline-position.html) for Windows 7 opt?

Flags: needinfo?(jfkthame)

I've seen that test fail similarly before - it's vulnerable to the Win7 issue with DirectWrite sometimes failing to load the font resource, and anything that perturbs the details of the test run, timing- or chunking-wise, can affect how likely it is to happen. (See bug 1396260, which is closed but was never really fixed, just somewhat mitigated.)

I think disabling the test on Win7 would be fine; there's nothing Win7-specific about it (the behavior being tested is platform-independent), and the graphics/font subsystem on Win7 is just too flaky to be worth worrying about.

Flags: needinfo?(jfkthame)
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8990a3df0feb
Disable skip-ink-multiline-position.html on Windows 7. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/a46a3719b9aa
Apply the overscroll transform to content fixed to the root (non-WebRender). r=tnikkel
Regressions: 1706530
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9216506 [details]
Bug 1705826 - Apply the overscroll transform to content fixed to the root (non-WebRender). r=tnikkel

Beta/Release Uplift Approval Request

  • User impact if declined: Overscroll effect will not apply to fixed content

Required for MR1 / Proton

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch is small and only affects rendering when the page is overscrolled
  • String changes made/needed:
Attachment #9216506 - Flags: approval-mozilla-beta?
Attachment #9217222 - Flags: approval-mozilla-beta?
Whiteboard: [proton-uplift]

Comment on attachment 9216506 [details]
Bug 1705826 - Apply the overscroll transform to content fixed to the root (non-WebRender). r=tnikkel

Approved for 89 beta 3, thanks.

Attachment #9216506 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9217222 [details]
Bug 1705826 - Disable skip-ink-multiline-position.html on Windows 7. r=jfkthame

Approved for 89 beta 3, thanks.

Attachment #9217222 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed for Beta 98.0b3 (20210422190146) and Nightly 90.0a1 (2021-04-22 (20210422213157) on MacOS 11.2.3 and Mac mini M1 11.0.1 in regards to applying the overscroll transform to content fixed to the root (non-WebRender).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.