1705838 - RollupPopups() in nsCocoaWindow.mm should close native menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

Some tests don't close all the menus they open (sometimes by accident). With non-native menus those leftover menus are closed whenever a regular window opens or closes, via RollUpPopups().

We should close native menus on the same occasions.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1705838 - Roll up native menus in RollUpPopups(). r=harry

This makes it much less likely that menus will stick around unintentionally
during automated tests.
It won't make much difference for user interactions with the browser, because
any user actions that cause calls to RollUpPopups() will usually cause the OS
to dismiss the native menu first. But in automation those things can happen
without user input.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbd84403e9e1
Roll up native menus in RollUpPopups(). r=harry

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fbd84403e9e1