Closed Bug 1705876 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28559 - Remove Elements from toJSON

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28559 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28559
Details from upstream follow.

b'Toshiaki Tanaka <zokutyou2@gmail.com>' wrote:

Remove Elements from toJSON

  1. PerformanceElementTiming
  2. LargestContentfulPaint
  3. LayoutShiftAttribution

These include element or node in each toJSONForBinding implementation.

Those should be removed because they use the default toJSON operation and
those should not include interfaces that themselves do not have a toJSON
operation. So we should remove them from the toJSON builder and update
the existing toJSON WPT tests,

Bug: 1199954
Change-Id: I282439c17485264f1621102e3d002a693d48c1f9
Reviewed-on: https://chromium-review.googlesource.com/2831166
WPT-Export-Revision: 63a333d2d05b1bf4ae0a6304affb970d37aa9f6a

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/element-timing/toJSON.html
Test toJSON() in PerformanceElementTiming.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/toJSON.html
Test toJSON() in LargestContentfulPaint.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfc27327c565
[wpt PR 28559] - Remove Elements from toJSON, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bfc27327c565

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.