1705972 - SVG Blur Filter feGaussianBlur cannot be rotated

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[frw700]

Attachment: _BUG_REPRO_Firefox_SVG_Blur_Filter_feGaussianBlur_cannot_be_rotated.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36 Edg/89.0.774.76

Steps to reproduce:

Have a div with CSS transform:rotate(45deg) which contains another element which has a horizontal svg blur filter via CSS filter property.

Actual results:

The blur filter axis is not rotated by 45deg and instead incorrectly stays horizontal.

Expected results:

The blur filter axis is at an angle of 45deg.

Comment 1

[frw700]

The bug is (atleast) in Firefox for Windows 10 and Android 9.
Blur filter axis is rotated correctly in Chrome 90 and EdgeHTML (UWP).
IIRC this is a regression and blur filter axis rotation used to work in Firefox about 1.5 years ago.

Comment 2

[Robert Longson [:longsonr]]

If this worked previously then finding a regression range via mozregression would be helpful.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::SVG' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[frw700]

Thanks, did not know about mozregression.
It is an regression and here is the bisect output:

-- build info --

app_name: firefox
build_date: 2020-08-25 07:06:04.085000
build_file: C:\Users-.mozilla\mozregression\persist\e45cf0154d7f--autoland--target.zip
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bj6d4ruUQ1GIekJiETHDMw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: e45cf0154d7fbb8cbcc827ede0623231ddfe8e6d
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e45cf0154d7fbb8cbcc827ede0623231ddfe8e6d&tochange=beeed787f909fc54651de3f0d1cdf4ac71ad3eef
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: bj6d4ruUQ1GIekJiETHDMw

-- log --

2021-04-18T23:26:10.694000: DEBUG : Found commit message:
Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw

Pretty straight forward, mostly just plumbing stuff through.

Differential Revision: https://phabricator.services.mozilla.com/D85666

2021-04-18T23:26:10.695000: DEBUG : Did not find a branch, checking all integration branches
2021-04-18T23:26:10.698000: INFO : The bisection is done.
2021-04-18T23:26:10.701000: INFO : Stopped

Comment 5

[frw700]

sorry, the build info in my previous comment is the last good build.
Here is the first bad build info:

app_name: firefox
build_date: 2020-08-25 08:08:19.605000
build_file: C:\Users-.mozilla\mozregression\persist\beeed787f909-shippable--autoland--target.zip
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MdcLcnmBTL2G3dmtpcAIRA/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: beeed787f909fc54651de3f0d1cdf4ac71ad3eef
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e9ff11c7fe044fd8bd6c1b76aa94dc0bfef54068&tochange=beeed787f909fc54651de3f0d1cdf4ac71ad3eef
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: MdcLcnmBTL2G3dmtpcAIRA

Comment 6

[Timothy Nikkel (:tnikkel)]

Since my patch just hooked up support for blur radius to be different in the x and y direction to the existing code in webrender it seems like my patch only exposed a bug inside webrender, so perhaps someone working inside webrender right now could take a first look?

Comment 7

[Glenn Watson [:gw]]

Appears consistent with chrome now, from a quick look. This was probably fixed by the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1749380.