1705979 - Add support for nearest filtered scaled composites to SWGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Glenn Watson [:gw]]

Attachment: 0001-WIP-Force-enable-non-opaque-compositor-surfaces-in-G.patch

In the SWGL compositor, it looks like we don't support the case of compositing a scaled surface with alpha and nearest filtering yet. See [1] and the handling of opaque above that.

To reproduce, apply the attached patch (which just allows non-opaque compositor surfaces to set the PREFER_COMPOSITOR_SURFACE flag), and then run:

./mach reftest --enable-webrender --setpref="layout.css.devPixelsPerPx=1.0" --setpref="gfx.webrender.software=true" layout/reftests/canvas/image-rendering-test.html

This is the only remaining blocker I'm currently aware of to enabling non-opaque compositor surfaces everywhere.

[1] https://searchfox.org/mozilla-central/source/gfx/wr/swgl/src/composite.h#432

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1705979 - Add support for nearest filtered scaled composites to SWGL. r?mattwoodrow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6196a07d7399
Add support for nearest filtered scaled composites to SWGL. r=mattwoodrow

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6196a07d7399

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1705979 - Make it easier to distinguish between copying and scaling in profile. r?mattwoodrow

With the copying and scaling code in one place, it gets a bit hard to see in the profile which one
is being used. This just moves some of the dispatching between the two up a level so they show up as
different functions in a profile.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f00e09e47084
Make it easier to distinguish between copying and scaling in profile. r=aosmond

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f00e09e47084