Closed Bug 1706004 Opened 3 years ago Closed 3 years ago

Make not refer to document.popupNode in Places.

Categories

(Firefox :: Bookmarks & History, task, P5)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: daisuke, Assigned: lesore0789, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Currently, we are referring to document.popupNode in Places to make context menus in some places. But, as the field is already deprecated, we should not use it.
In this bug, we will replace the places using document.popupNode with menupopup.triggerNode.

Severity: -- → N/A
Priority: -- → P3

The code has been removed, there is only one comment about document.popupNode at https://searchfox.org/mozilla-central/source/browser/components/places/PlacesUIUtils.jsm#464-465

Severity: N/A → S4
Priority: P3 → P5

Thisi s a trivial comment change bug to check the build environment is working.

Mentor: mak
Keywords: good-first-bug

Hi there, I am an outreachy applicant and would like to work on this bug. Can I be assigned to it?

Flags: needinfo?(mak)

Feel free to start working on it, bugs are assigned when the first patch is submitted. Thank you.

Flags: needinfo?(mak)
Assignee: nobody → lesore0789
Status: NEW → ASSIGNED
Attachment #9245195 - Attachment description: Bug 1706004 - Delete reference to document.popupNode in Places. r?Marco Bonardo → Bug 1706004 - Delete reference to document.popupNode in Places. r?mak
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/33152631ec40
Delete reference to document.popupNode in Places. r=mak

Please remember to record your contribution on Outreachy.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: