Closed
Bug 1706021
Opened 5 years ago
Closed 5 years ago
Move all tests dom/base/test/test_meta_viewport_* in their own directory
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: calixte, Assigned: calixte)
References
Details
(Whiteboard: [proton-uplift])
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Test test_user_select is failing because of some test_meta_viewport tests when some tests with pdf viewer are skipped: see https://bugzilla.mozilla.org/show_bug.cgi?id=1705327.
| Assignee | ||
Comment 1•5 years ago
|
||
Some meta_viewport tests make test_user_select.html failing when the infobar in pdf viewer is removed.
| Assignee | ||
Comment 2•5 years ago
|
||
Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a9cf18c6bb9
Move dom/base/test/test_meta_viewport* in their own directory r=botond
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
| Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9216715 [details]
Bug 1706021 - Move dom/base/test/test_meta_viewport* in their own directory
Beta/Release Uplift Approval Request
- User impact if declined: None
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch just moves some test files.
- String changes made/needed:
Attachment #9216715 -
Flags: approval-mozilla-beta?
Comment 6•5 years ago
|
||
Comment on attachment 9216715 [details]
Bug 1706021 - Move dom/base/test/test_meta_viewport* in their own directory
Approved for 89 beta 5, needed for the uplift in bug 1705327, thanks.
Attachment #9216715 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 years ago
|
Whiteboard: [proton-uplift]
Comment 7•5 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•