Closed Bug 1706085 Opened 5 months ago Closed 5 months ago

Smaller back arrow in subviews

Categories

(Firefox :: Theme, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified
firefox90 --- verified

People

(Reporter: ntim, Assigned: Gijs)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-icons] [priority:2a] [proton-uplift])

Attachments

(3 files, 1 obsolete file)

Attached image image.png

The back arrow is smaller than the subview arrows. I don't think that's intentional.

Blocks: proton-icons
No longer blocks: proton-hamburger-menu
Whiteboard: [proton-hamburger-menu] → [proton-icons]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Severity: -- → S2
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → Desktop
Regressed by: 1699889

The spec does use a smaller back button icon, but not quite as much smaller as what is in the release build, afaict.

Here's a better screenshot that allows comparing the implementation and spec

Attachment #9216829 - Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dec2215b8b1c
use a bigger back arrow for the hamburger menu, r=desktop-theme-reviewers,harry
Priority: -- → P2
Whiteboard: [proton-icons] → [proton-icons] [priority:2a]
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9216852 [details]
Bug 1706085 - use a bigger back arrow for the hamburger menu, r?mconley,sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Visual verification only
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small CSS + images change for MR1
  • String changes made/needed: Nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9216852 - Flags: approval-mozilla-beta?
Whiteboard: [proton-icons] [priority:2a] → [proton-icons] [priority:2a] [proton-uplift]

Comment on attachment 9216852 [details]
Bug 1706085 - use a bigger back arrow for the hamburger menu, r?mconley,sfoster

Approved for 89 Beta 3, thanks.

Attachment #9216852 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - Fixed in Beta 89.0b8 and latest Nightly 90.0a1 (2021-05-05) using Windows 10, macOS 10.15 and Ubuntu 20.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.