Closed
Bug 1706085
Opened 3 years ago
Closed 3 years ago
Smaller back arrow in subviews
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
VERIFIED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | verified |
| firefox90 | --- | verified |
People
(Reporter: ntim, Assigned: Gijs)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-icons] [priority:2a] [proton-uplift])
Attachments
(3 files, 1 obsolete file)
|
43.66 KB,
image/png
|
Details | |
|
44.67 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
image.png
The back arrow is smaller than the subview arrows. I don't think that's intentional.
|
||
Updated•3 years ago
|
Whiteboard: [proton-hamburger-menu] → [proton-icons]
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1280
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Severity: -- → S2
status-firefox88:
--- → unaffected
status-firefox89:
--- → affected
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → Desktop
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
|
|
Assignee | |
Comment 1•3 years ago
|
||
The spec does use a smaller back button icon, but not quite as much smaller as what is in the release build, afaict.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Here's a better screenshot that allows comparing the implementation and spec
Attachment #9216829 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dec2215b8b1c use a bigger back arrow for the hamburger menu, r=desktop-theme-reviewers,harry
|
||
Updated•3 years ago
|
Priority: -- → P2
Whiteboard: [proton-icons] → [proton-icons] [priority:2a]
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 6•3 years ago
|
||
Comment on attachment 9216852 [details]
Bug 1706085 - use a bigger back arrow for the hamburger menu, r?mconley,sfoster
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: Visual verification only
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small CSS + images change for MR1
- String changes made/needed: Nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9216852 -
Flags: approval-mozilla-beta?
|
||
Updated•3 years ago
|
status-firefox87:
--- → unaffected
status-firefox-esr78:
--- → unaffected
|
||
Updated•3 years ago
|
Whiteboard: [proton-icons] [priority:2a] → [proton-icons] [priority:2a] [proton-uplift]
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9216852 [details]
Bug 1706085 - use a bigger back arrow for the hamburger menu, r?mconley,sfoster
Approved for 89 Beta 3, thanks.
Attachment #9216852 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
||
Comment 9•3 years ago
|
||
Verified - Fixed in Beta 89.0b8 and latest Nightly 90.0a1 (2021-05-05) using Windows 10, macOS 10.15 and Ubuntu 20.
You need to log in
before you can comment on or make changes to this bug.
Description
•