1706136 - Update icons in about:logins

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

We have new icons to replace some of those used in about:logins. The document at https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates - it maps the paths of icons in m-c to the new icons where a change is planned. Not every icon was in scope - that's indicated in the spreadsheet as "No change planned

Comment 1

[Neil Deakin]

Attachment: Bug 1706136, update show/hide password icons in login manager, r=jaws

Comment 2

[Neil Deakin]

The icons that were changed appear in the 'Passwords' dialog (about:logins). The password field has an eye icon, and an eye hide icon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41221f0fdd59
update show/hide password icons in login manager, r=jaws

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/41221f0fdd59

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this bug on the latest Nightly 90.0a1 build (Build ID: 20210427221830) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

• The hide/show password icon is updated and correctly displayed.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Neil, do you want to request uplift to beta?

Comment 7

[Neil Deakin]

Comment on attachment 9218354 [details]
Bug 1706136, update show/hide password icons in login manager, r=jaws

Beta/Release Uplift Approval Request

• User impact if declined: New proton icons for about:logins
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No risk, just replaces two icons
• String changes made/needed: None

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218354 [details]
Bug 1706136, update show/hide password icons in login manager, r=jaws

Approved for 89 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/746e141d6ed9

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using Firefox Beta 89.0b9 (Build ID: 20210401185811) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The hide/show password icon is changed and correctly displayed.