1706307 - The text of the buttons from the "Import Error" and "Import Complete" is not vertically centered

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: text_downdisplayed.PNG

[Affected versions]:

• Firefox Nightly 90.0a1 (Build ID: 20210419221626)

[Affected Platforms]:

• Mac 11.2.3
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have saved on your computer a CSV file that contains only valid logins.

[Steps to reproduce]:

1. Navigate to the “about:logins” page.
2. Click on the Menu button.
3. Select the “Import from a File…” option.
4. Select the CSV file from prerequisites and click on the “Open” button from the “Import Logins File” picker.
5. Observe the text displayed on the “Done” button.

[Expected result]:

• The string is centered.

[Actual result]:

• The text is not vertically centered.

[Regression]

• The issue is not reproducible with older Nightly 89.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
  Last good revision: 8aa1b80a8c6b66cccc2e37080fbf6197eee8d801
  First bad revision: 1716229005d8b97f305bd663b8bc8d3fec4a4f3a
  Pushlog: link
  From this pushlog I think the patch for Bug 1700109 introduced this behavior.

[Notes]:

• Attached a screenshot of the issue.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1706307 - Use min-width and min-height on import dialog buttons to accommodate to different text sizes. r=jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fe2b4c9d5e5
Use min-width and min-height on import dialog buttons to accommodate to different text sizes. r=jaws

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6fe2b4c9d5e5

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 90.0a1 (Build ID: 20210422213157) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The text of the buttons from the "Import Error" and "Import Complete" modals is correctly centered.