Redirect Search Tips aren't the right color
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-uplift])
Attachments
(2 files)
|
53.64 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Screen Shot 2021-04-20 at 10.15.57 AM.png
The Search Tips that are shown when going to a search engine homepage are the color of the unfocused address bar. Screenshot attached.
The issue is that our Urlbar background color rules mostly depend on whether the Urlbar is [focused="true"] or not. Redirect Search Tips are a unique case where the Urlbar is open but not focused. Those CSS rules should consider both whether the Urlbar is focused and whether it's open.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5be9c4edf373 Apply Urlbar background-color rules when it is focused or open. r=dao
|
|
Assignee | |
Comment 3•3 years ago
|
||
[Tracking Requested - why for this release]:
Required for MR1/Proton. The Urlbar background will be the wrong color in some cases.
I'll request uplift tomorrow after I've verified the fix in Nightly.
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
Comment on attachment 9217094 [details]
Bug 1706363 - Apply Urlbar background-color rules when it is focused or open. r?dao!
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1/Proton. Urlbar background-color will be wrong in some cases.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small CSS-only fix. Verified in Nightly.
- String changes made/needed:
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9217094 [details]
Bug 1706363 - Apply Urlbar background-color rules when it is focused or open. r?dao!
Approved for 89 Beta 3, thanks.
|
|
||
Comment 7•3 years ago
|
||
| bugherder uplift | ||
Description
•