Closed
Bug 1706365
Opened 3 years ago
Closed 3 years ago
Support moving and non-empty destruction of mozilla::Queue
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(2 files)
Currently the code requires that the queue is empty before it is destroyed, and doesn't delete its copy or move constructors, so will be unsound if copied/moved when non-empty.
|
Assignee | |
Comment 1•3 years ago
|
||
This allows the mozilla::Queue type to be used more easily and without
causing assertion failures, leaks, or unsafe behaviour.
|
||
Updated•3 years ago
|
Attachment #9217107 -
Attachment description: Bug 1706365 - Safely invoke destructors and constructors in mozilla::Queue, → Bug 1706365 - Part 1: Safely invoke destructors and constructors in mozilla::Queue,
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ad05b43479e Part 1: Safely invoke destructors and constructors in mozilla::Queue, r=xpcom-reviewers,kmag https://hg.mozilla.org/integration/autoland/rev/21020c5c5fce Part 2: Add tests for mozilla::Queue, r=xpcom-reviewers,kmag
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8ad05b43479e
https://hg.mozilla.org/mozilla-central/rev/21020c5c5fce
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•