1706434 - Make devtools/client/framework/test/browser_toolbox_zoom_popup.js pass with native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

This test checks that various popups open in the right place, even if the devtools UI is zoomed.
One of the menus it checks is a native menu; it's the overflow menu for the tabs in the inspector's right pane (Layout / Computed / Changes / ...).
We cannot query the true screen rect for a native menu, but we can query the position at which we asked the system to display it, which is all that the test needs to check.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1706434 - For native menus, make XULPopupElement.getOuterScreenRect() return the rect that the menu was initialized with. r=tnikkel

The position of this rectangle is the position at which we asked the OS to open the menu.

Depends on D112803

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1706434 - Use getOuterScreenRect instead of getBoxQuads to query the menu rect in this test. r=jdescottes

getBoxQuads does not work with native menus because there is no visible layout
box for a native menu's DOM element.
getOuterScreenRect works with both native and non-native menus.
For non-native menus it is fully accurate, and for native menus it has a useful
position component which reflects the position at which we asked the OS to open
the menu, which is enough to test what the test wants to test.

Depends on D112804

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c2c78ce3f6
For native menus, make XULPopupElement.getOuterScreenRect() return the rect that the menu was initialized with. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/4e03c09c8d1c
Use getOuterScreenRect instead of getBoxQuads to query the menu rect in this test. r=jdescottes

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a7c2c78ce3f6
https://hg.mozilla.org/mozilla-central/rev/4e03c09c8d1c

Comment 5

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e7ae9a5d00c
https://hg.mozilla.org/releases/mozilla-beta/rev/0bfcddaac572