1706470 - Bookmark star icon uses OS color making it less noticable

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect, P5)

Description

[Tom S. (please needinfo tschuster)]

Attachment: Nightly

It seems like Firefox recently started using some OS theme color for the bookmark icon when a page is bookmarked. For me that color doesn't seem appropriate as it's quite low contrast? (sorry I am not great with color terms)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Firefox 87

Comment 2

[Marco Bonardo [:mak]]

I assume this is Linux, on other platforms we don't use the system accent. I think this is a recent change, if you can find the bug that made it, it would be very useful.

Comment 3

[Tom S. (please needinfo tschuster)]

Yeah this on Linux. This was apparently changed by bug 1705741. However while bisecting this I noticed that we used some out-of-place cyan color before, so this is at least better and maybe shouldn't be changed.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Curious, which GTK theme is this? Maybe we can increase the contrast of the accent color a bit.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(I thought it was Yaru-mate, but it's not, or at least I get a darker color using that theme)

Comment 6

[Tom S. (please needinfo tschuster)]

This is Mint-Y-Dark on Linux Mint Cinnamon.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1705741

Comment 8

[Tom S. (please needinfo tschuster)]

I think the problem is actually worse with the download icon indicating that a download finished.

Comment 9

[Romain Testard [:RT]]

NIing Asa here to help understand if we should adjust the contrast for accent color on Linux.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot with gtk3-widget-factory

I think given the rendering of the other GTK widgets using this theme this is fine, tbh. I looked at the relevant GTK theme and here are the colors it defines:

@define-color theme_fg_color #DADADA;
@define-color theme_text_color #DADADA;
@define-color theme_bg_color #383838;
@define-color theme_base_color #404040;
@define-color theme_selected_bg_color #8fa876;
@define-color theme_selected_fg_color #ffffff;
@define-color fg_color #DADADA;
@define-color text_color #DADADA;
@define-color bg_color #383838;
@define-color base_color #404040;
@define-color selected_bg_color #8fa876;
@define-color selected_fg_color #ffffff;
@define-color insensitive_bg_color #3d3d3d;
@define-color insensitive_fg_color alpha(#dadada, 0.5);
@define-color insensitive_base_color #404040;
@define-color theme_unfocused_fg_color #DADADA;
@define-color theme_unfocused_text_color #DADADA;
@define-color theme_unfocused_bg_color #383838;
@define-color theme_unfocused_base_color #404040;
@define-color borders #292929;
@define-color unfocused_borders #292929;
@define-color warning_color #f27835;
@define-color error_color #FC4138;
@define-color success_color #73d216;
@define-color placeholder_text_color #A8A8A8;
@define-color content_view_bg #404040;
@define-color wm_title #DADADA;
@define-color wm_unfocused_title alpha(#ded6d6, 0.5);
@define-color wm_bg #2f2f2f;
@define-color wm_bg_unfocused #333333;
@define-color wm_highlight #373737;
@define-color wm_shadow alpha(black, 0.35);
@define-color wm_button_close_bg #cc575d;
@define-color wm_button_close_hover_bg #d7787d;
@define-color wm_button_close_active_bg #be3841;
@define-color wm_icon_close_bg #2f343f;
@define-color wm_button_hover_bg #454C5C;
@define-color wm_button_active_bg #8fa876;
@define-color wm_button_hover_border #262932;
@define-color wm_icon_bg #90939B;
@define-color wm_icon_unfocused_bg #666A74;
@define-color wm_icon_hover_bg #C4C7CC;
@define-color wm_icon_active_bg #ffffff;

At a glance I don't se any color that we could use from there that has more contrast. We could lighten it up a bit with something like color-mix(in srgb, -moz-accent-color 100%, white 10%) or such, but that's just going to make other themes look weird so I'd rather not.

Comment 11

[Asa Dotzler [:asa]]

I don't believe this is an accessibility issue. The contrast of the icon color is sufficient against its background color for meeting accessibility guidelines. It does appear to be a general usability regression though.

Comment 12

[Pablo]

checked the issue today on nightly run on ubuntu 20 64bit with latest nightly 92.0a1
star in urlbar, star in search suggestions and star in one-offs area is orange.

Comment 13

[Marco Bonardo [:mak]]

Based on comment 10, we consider this an enhancement request, where we could maybe artificially increase the contrast using color-mix. Not respecting the system colors may also not be liked by other users on Linux.

Comment 14

[Dão Gottwald [:dao]]

The accent color was picked for toolbarbuttons more broadly rather than just for the address bar, so moving this to theme.

Also closing this as wontfix as we're not planning on going back to hardcoding the color on Linux.