1706490 - Make browser_webconsole_network_messages_status_code.js work with native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Harry Twyford]

This test seems to be testing useless behaviour: a right Cmd click opening a context menu. Reading bug 1421213, where the test was introduced, it looks like it's the result of a miscommunication in the review process where the reviewer wanted to make sure that Ctrl+clicking on Mac also opened the context menu. The window object here also appears to be the hidden window. Which is all to say: the test is busted as-is. Even without native context menus, you can see it opens context menus over context menus, far away from the node its supposed to be clicking on. It seems to pass now sort of accidentally, with a subsequent test accidentally cleaning it up.

I'm going to remove the right Cmd+click case, and clean up the test.

Comment 1

[Harry Twyford]

Attachment: Bug 1706490 - Make browser_webconsole_network_messages_status_code.js work with native context menus. r?#mac-reviewers

The openContextMenu() helper does the same thing this test does now: dispatches a MouseEvent to a specified node. Using it allows us to clean up the test considerably.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30af39798ccf
Make browser_webconsole_network_messages_status_code.js work with native context menus. r=mac-reviewers,mstange

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/30af39798ccf

Comment 4

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d54e3ff08571