Closed Bug 1706542 Opened 4 years ago Closed 4 years ago

Intermittent layout/svg/tests/test_filter_crossorigin.html: Testcase loaded from example.org | image comparison (==), max difference: 255, number of differing pixels: 5000

Categories

(Core :: SVG, defect, P5)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dholbert)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=337253490&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XZoMpNd9RfOT4D0gvsi6gw/runs/0/artifacts/public/logs/live_backing.log


[task 2021-04-21T04:01:18.787Z] 04:01:18    ERROR - GECKO(12015) | REFTEST TEST-UNEXPECTED-FAIL | Testcase loaded from example.org | image comparison (==), max difference: 255, number of differing pixels: 5000
[task 2021-04-21T04:01:18.808Z] 04:01:18     INFO - TEST-INFO | started process screentopng
[task 2021-04-21T04:01:18.975Z] 04:01:18     INFO - TEST-INFO | screentopng: exit 0
[task 2021-04-21T04:01:18.976Z] 04:01:18     INFO - Buffered messages logged at 04:01:18
[task 2021-04-21T04:01:18.977Z] 04:01:18     INFO - TEST-PASS | layout/svg/tests/test_filter_crossorigin.html | reftest comparison: == Testcase loaded from mochi.test Reference: black/yellow 
[task 2021-04-21T04:01:18.977Z] 04:01:18     INFO - Buffered messages finished
[task 2021-04-21T04:01:18.977Z] 04:01:18     INFO - TEST-UNEXPECTED-FAIL | layout/svg/tests/test_filter_crossorigin.html | reftest comparison: == Testcase loaded from example.org Reference: yellow/black 
[task 2021-04-21T04:01:18.978Z] 04:01:18     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2021-04-21T04:01:18.978Z] 04:01:18     INFO -     assertSnapshots@SimpleTest/WindowSnapshot.js:86:5
[task 2021-04-21T04:01:18.978Z] 04:01:18     INFO -     run@layout/svg/tests/test_filter_crossorigin.html?currentTestURL=layout%2Fsvg%2Ftests%2Ftest_filter_crossorigin.html&closeWhenDone=1&showTestReport=false&expected=pass:40:18
[task 2021-04-21T04:01:18.979Z] 04:01:18     INFO - GECKO(12015) | MEMORY STAT | vsize 2556MB | residentFast 147MB | heapAllocated 8MB
[task 2021-04-21T04:01:18.979Z] 04:01:18     INFO - TEST-OK | layout/svg/tests/test_filter_crossorigin.html | took 658ms```

In the failure data-URI screenshots (at least in https://treeherder.mozilla.org/logviewer?job_id=338341657&repo=try&lineNumber=12080 ), the black rectangle is missing in the testcase, but present in the reference case.

This indicates that the external filter failed to load in the testcase -- or perhaps that it wasn't loaded by the time that we took the screenshot?

The JS is keyed off of the body load event, which I think means it shouldn't happen until the iframes have fired their own load events; but as a first pass diagnostic, it'd be worth investigating whether adding a bit of delay (e.g. a few executeSoon() ticks) to see if that helps here.

That would hopefully tell us whether this is just a race condition between load events & rendering, vs. an actual complete failure to render the filter.

Summary: Intermittent Testcase loaded from example.org | image comparison (==), max difference: 255, number of differing pixels: 5000 → Intermittent layout/svg/tests/test_filter_crossorigin.html: Testcase loaded from example.org | image comparison (==), max difference: 255, number of differing pixels: 5000

This test has a fission-specific failure right now, where the failure looks
like a case where the cross-origin resource simply hasn't loaded, or hasn't
loaded yet.

This patch adds a short delay (60 "executeSoon" ticks, each of which spin the
event loop). This doesn't make the test take appreciably longer on my machine,
but it does introduce a short delay. If it helps, it'll let us know that
there's simply a race condition which is causing this test's snapshots to be
taken before its iframes' resources are ready.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acc3fea06c51 Add a short executeSoon delay to test_filter_crossorigin.html, as a possible workaround/diagnostic. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: