1706554 - FramePointerStackWalk shouldn't take aFirstFramePC

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In bug 1515229, aFirstFramePC was added to MozStackWalk().
But not to FramePointerStackWalk(), because it's already given a start frame through aBp.

However, bug 1515229 mistakenly added aFirstFramePC to the empty definition of FramePointerStackWalk (only used on unsupported platforms.)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1706554 - Remove aFirstFramePC from no-op FramePointerStackWalk definition - r?glandium

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1515229

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/885e78c7baa9
Remove aFirstFramePC from no-op FramePointerStackWalk definition - r=glandium

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/885e78c7baa9

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gerald, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I don't think it's that important, it's only fixing potential build issues on unsupported platforms. Trivial for anyone to backport if they need it.

Comment 7

[Mike Hommey [:glandium]]

not(Tier 1) != unsupported

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I don't know (enough) about tiers.
To clarify: That function is on the #else branch of #if defined(XP_WIN) || defined(XP_MACOSX) || defined(XP_LINUX).
Are there other systems that we should support? Reading https://firefox-source-docs.mozilla.org/build/buildsystem/supported-configurations.html , I guess this would be tier-3?

Anyway, it's a one-liner build fix, I'd be happy to uplift it if you think it should be in Firefox 89 to help tier>=3 friends.

Comment 9

[Mike Hommey [:glandium]]

Yes, please.

Comment 10

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 9217322 [details]
Bug 1706554 - Remove aFirstFramePC from no-op FramePointerStackWalk definition - r?glandium

Beta/Release Uplift Approval Request

• User impact if declined: Tier-3 platforms build failures.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's only removing an argument in the function definition, to match the declaration. The function itself is empty in that configuration.
• String changes made/needed:

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9217322 [details]
Bug 1706554 - Remove aFirstFramePC from no-op FramePointerStackWalk definition - r?glandium

No risk for tier 1 platforms, approved for beta, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4015ca288ec