1706616 - Add telemetry for URL query string stripping

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Comment 1

[Tim Huang[:timhuang]]

We plan to add telemetry probes for following items

• Number of query stripping happens
• Ratio of navigations has stripped query strings
• Where stripping happens, navigate or redirect

Comment 2

[Tim Huang[:timhuang]]

Attachment: review-request.md

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1706616 - Part 1: Add telemetry probe for query stripping. r?dimi

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1706616 - Part 2: Add a test for the query stripping telemetry. r?dimi

Depends on D117006

Comment 5

[Chris H-C :chutten]

Comment on attachment 9224939 [details]
review-request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Tim Huang is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8446bda339b7
Part 1: Add telemetry probe for query stripping. r=dimi,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/443f5f8fe809
Part 2: Add a test for the query stripping telemetry. r=dimi

Comment 7

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1706616) for causing bc failures in browser_urlQueryStringStripping_telemetry.js

Backout link
Push with failures
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d901239cc7a
Part 1: Add telemetry probe for query stripping. r=dimi,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/7979a6bdcdae
Part 2: Add a test for the query stripping telemetry. r=dimi

Comment 9

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1706616) for causing failures in browser_urlQueryStringStripping_telemetry.js
Backout link
Push with failures
Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/720d658b9411
Part 1: Add telemetry probe for query stripping. r=dimi,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/0c03de83f9a8
Part 2: Add a test for the query stripping telemetry. r=dimi

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/720d658b9411
https://hg.mozilla.org/mozilla-central/rev/0c03de83f9a8