Closed
Bug 1706649
Opened 4 years ago
Closed 4 years ago
ExperimentAPI shouldn't modify store in getRemoteConfig
Categories
(Firefox :: Nimbus Desktop Client, task, P1)
Firefox
Nimbus Desktop Client
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
Attachments
(1 file)
Right now ExperimentAPI.jsm is mutating the store in this line, which ends up removing targeting.
Although functionally speaking this isn't a problem since targeting isn't used after the RemoteSettingsExperimentLoader, we shouldn't be modifying the store entry as a side effect
|
Reporter | |
Updated•4 years ago
|
Type: defect → task
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/EXP-1217
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → andrei.br92
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9217696 -
Attachment description: WIP: Bug 1706649 - ExperimentAPI shouldn't modify store in getRemoteConfig → Bug 1706649 - ExperimentAPI shouldn't modify store in getRemoteConfig
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7164e81df457
ExperimentAPI shouldn't modify store in getRemoteConfig r=k88hudson
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•