moz-phab stops me from updating the patch if the reviewer set their state to away
Categories
(Conduit :: moz-phab, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: alwu, Assigned: sheehan)
References
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
So my patch is like Bug XXX - YYY. r?ZZZ and I already got r+ from the reviewer, and my reviewer recently went to vacation and set its status to away and not accept any new reviews.
Then I use moz-phab submit to update my patch, but I got the error message like following
Unable to submit commits:
SOME COMMIT NUMBER Bug XXX - YYY. r?ZZZ
- ZZZ is not available until 2021-07-18 15:00
Because my patch is already got r+, moz-phab submit should not prevent me from updating the patch. In order to update that, I have to manually remove r?zzz from my local patch, which is annoying.
Updated•4 years ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
You can use -f to submit the stack anyways, if this is the only error stopping you from submitting. I'll add a hint about -f to the error message.
| Assignee | ||
Comment 2•1 year ago
|
||
Add a note to the "unavailable reviewers" error message that -f can be used
to bypass the error. moz-phab has this capability internally as it will
consider this warning to be non-fatal with -f passed, but the feature isn't
discoverable for someone who just wants to submit a patch.
| Assignee | ||
Updated•1 year ago
|
Description
•