1706674 - Error when saving snapshot (related to unicode characters in a path)

Status: UNCONFIRMED

(DevTools :: Memory, defect, P2)

Description

[w.729993031]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36

Steps to reproduce:

open the devtools memory and click the Save snapshot button

Actual results:

保存

保存此快照时发生错误。

Error while performing task "readHeapSnapshot": [Exception... "File error: Not found" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: resource://devtools/shared/heapsnapshot/HeapAnalysesWorker.js :: <TOP_LEVEL> :: line 51" data: no]
@resource://devtools/shared/heapsnapshot/HeapAnalysesWorker.js:51:45
createHandler/<@resource://devtools/shared/worker/helper.js:85:24

Expected results:

must not to message the error

(i use the china firefox and i dont know how to share the error report)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I was able to reproduce this issue:

• create a 保存 folder on your machine
• open the memory panel
• take a snapshot
• save it in 保存 folder
• click the memory "import" panel and select the file in the 保存 folder

In the panel, there's :

There was an error processing this snapshot.
Error while performing task "readHeapSnapshot": [Exception... "File error: Not found" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: resource://devtools/shared/heapsnapshot/HeapAnalysesWorker.js :: <TOP_LEVEL> :: line 51" data: no]
@resource://devtools/shared/heapsnapshot/HeapAnalysesWorker.js:51:45
createHandler/<@resource://devtools/shared/worker/helper.js:85:24

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for checking Nicolas! I could also reproduce when importing, but not when saving.

(In reply to w.729993031 from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36

Steps to reproduce:

This looks similar to Bug 1382493, but the other bug only occurs when importing a file with Unicode characters.
Can you confirm that you are getting an error when you are saving, not when you are importing?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

It looks like we're hitting these lines: https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/shared/heapsnapshot/AutoMemMap.cpp#38-39

Comment 5

[Julien Wajsberg [:julienw]]

I started working on this in bug 1651255 but never finished the patch. There's a patch up with review comments there, if somebody want to pick it up. Otherwise I will try to look at it again soon.

Comment 6

[w.729993031]

how can i fix this bug?

Comment 7

[Julien Wajsberg [:julienw]]

(In reply to w.729993031 from comment #6)

how can i fix this bug?

Until we fix the bug, I suggest that you rename the file using only plain ascii (8-bits / latin) characters. Sorry about that :/

Comment 8

[w.729993031]

(In reply to Julien Wajsberg [:julienw] from comment #7)

(In reply to w.729993031 from comment #6)

how can i fix this bug?

Until we fix the bug, I suggest that you rename the file using only plain ascii (8-bits / latin) characters. Sorry about that :/

https://upload.cc/i1/2021/04/24/wTQmIv.png

i dont create a fxsnapshot file so i dont know how to fix this bug? can you share me a Tutorials？

Comment 9

[w.729993031]

but i can cahe the fxsnapshot file and open he not talk me the error..

Comment 10

[Julian Descottes [:jdescottes]]

Thanks, I was suspecting that this bug was about saving and not importing.

But I didn't manage to reproduce the bug even with a profile name using unicode characters. Maybe some other folder needs to have unicode characters to create the issue. I think we should block it on Bug 1651255 and revisit once the other bug it fixed.