1706732 - Make `--backgroundtask backgroundupdate` send Glean pings with non-Desktop Firefox Glean application ID

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1703318 added a new Glean backgroundupdate ping, but it's sent with Desktop Firefox's Glean application ID. Bug 1704871 allows to send it with its own application ID. After Bug 1704878, we'll be able to use the new application ID; this ticket tracks doing so.

Comment 1

[Jeff Klukas [:klukas] (UTC-4)]

In Bug 1704878, probe-scraper now has "firefox.desktop.background.update" registered as an app_id.

If I’m understanding the new FOG interface correctly, this would mean changing https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/BackgroundTask_backgroundupdate.jsm#314 to be:

FOG.initializeFOG(gleanRoot, "firefox.desktop.background.update");

?ni :nalexander Do you have everything you need to go ahead and make this code change to include the new app_id?

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1706732 - Send "background-update" Glean pings with Glean application ID "firefox.desktop.background.update". r?chutten

The Glean application ID is not included in the Glean ping itself, so
I haven't updated the existing Marionette test for this custom ping.
We'll verify by inspecting the data in the metrics pipeline directly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c49b44eba9b
Send "background-update" Glean pings with Glean application ID "firefox.desktop.background.update". r=chutten

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c49b44eba9b

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Jeff Klukas [:klukas] (UTC-4) from comment #1)

In Bug 1704878, probe-scraper now has "firefox.desktop.background.update" registered as an app_id.

If I’m understanding the new FOG interface correctly, this would mean changing https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/BackgroundTask_backgroundupdate.jsm#314 to be:

FOG.initializeFOG(gleanRoot, "firefox.desktop.background.update");

?ni :nalexander Do you have everything you need to go ahead and make this code change to include the new app_id?

Done. Thanks for all of your help, :klukas!

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 9217876 [details]
Bug 1706732 - Send "background-update" Glean pings with Glean application ID "firefox.desktop.background.update". r?chutten

Beta/Release Uplift Approval Request

• User impact if declined: None.

• Is this code covered by automated tests?: Yes

• Has the fix been verified in Nightly?: Yes

• Needs manual test from QE?: No

• If yes, steps to reproduce:

• List of other uplifts needed: None

• Risk to taking this patch: Low

• Why is the change risky/not risky? (and alternatives if risky): This impacts metrics sent by the background update system from Bug 1689520, which is compiled into Beta 89 but preffed off by default. Right now, any Beta that enables background update will send Glean metrics as "firefox.desktop", where it will cause noise with regular Firefox metrics. This very small change identifies background update metrics as a new application "firefox.desktop.background.update".

  This is working in Nightly; we have data flowing.

  We would like to stage the rollout of background updates in Beta 89; this blocks that.

• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9217876 [details]
Bug 1706732 - Send "background-update" Glean pings with Glean application ID "firefox.desktop.background.update". r?chutten

Low risk, has tests and baked on nightly, , approved for 89 beta 9, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec15763cd250