in operator fails to find private method on class
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | unaffected |
firefox90 | --- | disabled |
People
(Reporter: mgaudet, Assigned: mgaudet)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
I'm preparing an update of tests262, and have found some new failures related to private methods + ergonomic brand checks in test262 revision eca69e2c95972a4c5780ef58fe1f1e53e871b9b1
- test262/language/expressions/in/private-field-presence-method.js
- test262/language/expressions/in/private-field-presence-method-shadowed.js
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Setting regressed-by flag, but also marking fx-90 as disabled, as ergonomic-brand checks are flagged off currently.
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1662559
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
This ends up changing the NoThrow condition on CheckPrivateField to instead emulate the object check of JSOp::In instead.
As well, to create PrivateOpEmitter::Kind::ErgonomicBrandCheck, it's no longer aliased to the ElemOpEmitter::Kind enum.
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Backed out for failures on private-reflect-01.js
backout: https://hg.mozilla.org/integration/autoland/rev/56f63d7627649b815f2a9b0c3c366e2c817c19ca
failure log: https://treeherder.mozilla.org/logviewer?job_id=338849680&repo=autoland&lineNumber=4986
[task 2021-05-05T18:31:03.115Z] TEST-PASS | js/src/jit-test/tests/fields/private-right-side-1.js | Success (code 0, args "") [0.1 s]
[task 2021-05-05T18:31:03.118Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:2:17 SyntaxError: private names aren't valid in this context
[task 2021-05-05T18:31:03.118Z] Stack:
[task 2021-05-05T18:31:03.118Z] rp@/builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:2:18
[task 2021-05-05T18:31:03.118Z] @/builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:11:3
[task 2021-05-05T18:31:03.118Z] Exit code: 3
[task 2021-05-05T18:31:03.118Z] FAIL - fields/private-reflect-01.js
[task 2021-05-05T18:31:03.118Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/fields/private-reflect-01.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:2:17 SyntaxError: private names aren't valid in this context (code 3, args "") [0.1 s]
[task 2021-05-05T18:31:03.119Z] INFO exit-status : 3
[task 2021-05-05T18:31:03.119Z] INFO timed-out : False
[task 2021-05-05T18:31:03.119Z] INFO stderr 2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:2:17 SyntaxError: private names aren't valid in this context
[task 2021-05-05T18:31:03.119Z] INFO stderr 2> Stack:
[task 2021-05-05T18:31:03.119Z] INFO stderr 2> rp@/builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:2:18
[task 2021-05-05T18:31:03.119Z] INFO stderr 2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/fields/private-reflect-01.js:11:3
[task 2021-05-05T18:31:03.120Z] TEST-PASS | js/src/jit-test/tests/fields/private-throwing-initializer.js | Success (code 0, args "") [0.1 s]
Assignee | ||
Comment 9•4 years ago
|
||
(Landed after goofing my merge-conflict-resolution, hence the backout)
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c41dfc1a30ee
https://hg.mozilla.org/mozilla-central/rev/c85486b5c6ba
Description
•