1706806 - Make devtools/client/inspector/markup/test/browser_markup_load_01.js work with native menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

This test kept a menu open for too long.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1706806 - Use clickOnInspectMenuItem in browser_markup_load_01.js. r=#mac-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bc6d559d013
Use clickOnInspectMenuItem in browser_markup_load_01.js. r=mac-reviewers,harry

Comment 3

[Markus Stange [:mstange]]

It's possible that this patch is causing the test to time out with non-native menus: https://treeherder.mozilla.org/jobs?repo=try&tier=1&revision=7366da6b53c02be86a828a3757797016dc89f0cc&selectedTaskRun=CFKU5xaERjylN8BCAVLoMA.0

Comment 4

[Markus Stange [:mstange]]

Actually, I think before this fix, the test wasn't working! It was right-clicking in content and then immediately sending a keypress. However, the content area context menu opens asynchronously. So the keypress probably always went into thin air! With the patch that just landed, we're correctly waiting for the menu to open, and then correctly inspecting the clicked element. But we seem to be timing out while waiting for the menu to open. The right click happens during page load, so it's possible that the context menu may not open at all in some cases.

So then it would be better to disable the test, and file a follow-up bug to make it do what it wanted to do in the first place.

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1706806 - Disable browser_markup_load_01.js due to timeouts. r=#mac-reviewers,jdescottes

Comment 6

[Markus Stange [:mstange]]

Sheriffs, before backing out this patch, please consider landing https://phabricator.services.mozilla.com/D113057 instead, to disable the test.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c409ea0b91d4
Disable browser_markup_load_01.js due to timeouts. DONTBUILD

Comment 8

[Cosmin Sabou [:CosminS]]

This looks to be timing out on OSX webrender opt/debug so far: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=0bc6d559d01347f397c4af074cf7f36990653ce0&test_paths=devtools%2Fclient%2Finspector%2Fmarkup%2Ftest%2F
Retriggered on other platforms to see the timeout rate.

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0bc6d559d013
https://hg.mozilla.org/mozilla-central/rev/c409ea0b91d4

Comment 10

[Markus Stange [:mstange]]

Re-enabling the test is tracked in bug 1706833.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/531babf2bbdf
https://hg.mozilla.org/releases/mozilla-beta/rev/f4de1f36d30c