1706811 - Explicitly start the media sink after re-creating it, if it was playing before

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

When updating the output capture in MDSM, we didn't restart the sink after recreating a new sink. The sink would actually get started later by MaybeStartPlayback() that would be checked periodly in the decoding and completed state.

However, we should make it explicitly start if the sink was playing before we recreate it, like what we did for SetSink()

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1706811 - explicitly restart the media sink in 'UpdateOutputCaptured()' if it was playing before. r?bryce.

When updating the output capture in MDSM, we didn't restart the sink after recreating it. The sink would actually get started later by MaybeStartPlayback() that would be checked periodly in the decoding and completed state.

However, we should make it explicitly start if the sink was playing before we recreate it, like what we did for SetSink() [1]

[1] https://searchfox.org/mozilla-central/rev/08013752b4638f01d41d2a38ca7bd741bc572c86/dom/media/MediaDecoderStateMachine.cpp#3803-3814

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ec9b46cd0ea
explicitly restart the media sink in 'UpdateOutputCaptured()' if it was playing before. r=bryce.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6ec9b46cd0ea