1706816 - Close open native menus when another native menu wants to open

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

Bug 1701843 just added a test which first opens a context menu inside about:config, and then a context menu on a bookmark. It doesn't close the first menu before the second.

Native context menus currently fail that test because the first menu isn't closed properly.

We can close the first menu automatically if we encounter this situation.

This situation is extremely unlikely to arise in regular Firefox usage: If the user right-clicks something else while a context menu is open, macOS closes the old context menu first, and then it tells us about the right click.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1706816 - If we're asked to open a native menu when another menu is already open, close the other menu first. r=tnikkel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca9e268a4cd
If we're asked to open a native menu when another menu is already open, close the other menu first. r=harry

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aca9e268a4cd

Comment 4

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/80b3040803f9