1706903 - JS error in target configuration when using the MBT

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open FF
• open MBT
• open a new FF window

ER: no error should be logged
AR: 3 errors

JavaScript error: resource://devtools/server/actors/target-configuration.js, line 111: TypeError: can't access property "inRDMPane", this._browsingContext is undefined

https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/server/actors/target-configuration.js#111

    const rdmEnabledInPreviousBrowsingContext = this._browsingContext.inRDMPane;

However _browsingContext can be null per https://searchfox.org/mozilla-central/rev/72951aa826642f048da4c6b71b8b3e36a9606dcd/devtools/server/actors/target-configuration.js#79

    this._browsingContext = this.watcherActor.browserElement?.browsingContext;

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1706903 - [devtools] Don't handle new browsing contexts in target configuration actor for the Browser Toolbox. r=jdescottes.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1704736

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

_

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4796bd92fc8d
[devtools] Don't handle new browsing contexts in target configuration actor for the Browser Toolbox. r=jdescottes.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4796bd92fc8d

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

the error is visible in the logs but don't cause any real harm, so no need to uplift the patch IMO