1706935 - Update about:addons and about:preferences sidebar icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: extension icon bug

Affected versions

• Fx89.0b2
• Fx90.0a1

Affected platforms

• Windows 10
• Ubuntu 18.04
• macOS 11

Steps to reproduce

1. Launch Firefox.
2. Navigate to about:addons
3. Inspect all the available icons.

Expected result

• All the icons are in accordance to the new proton design.

Actual result

• The extension icon is still from the old design

Regression range

• This is not a regression.

Additional notes

• Other icons have the new design implemented (e.g. Plugins icon)

Comment 1

[Mark Striemer [:mstriemer]]

The theme icon was also reported in bug 1704746. Since the plugin icon has been updated and we do have new icons for most of these (I'm not seeing one for Dictionaries or Available Updates, but maybe we can find placeholders) it probably makes sense to update these icons. Alternatively we could revert the plugin icon to the old version for the Plugins category.

Romain, how should we proceed here? Currently the icons are mixing old and new. You said bug 1704746 was out of scope, but in my opinion we need to do something here to be consistent.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: image.png

Likewise for about:preferences, it is mixing new and old icons

Comment 3

[Romain Testard [:RT]]

Agreed that it would be nice to make this change for consistency reasons. Making this one a P2a. Do you think about:preferences and about :addons should be addressed in the same bug? If so about:preferences should be done with higher priority given it's a more visible area.

Comment 4

[katieC]

There are new icons for Comment 2 screenshot about:preferences
General = settings-20.svg (gear)
Home = home-20.svg (house)
Search = search-20.svg (magnifying glass)
Privacy & Security = lock-20.svg (lock)
Sync = sync-20.svg (2 arrows in circle)
Experiments = experiments-20.svg (atom + dots)

For about:add-ons
Recommendations = highlights-20.svg (3 sparkle stars)
Extensions = extension-20.svg (outline puzzle piece
Themes = themes-20.svg (wide paint brush)
Plugins = plugin-20.svg (lego block)

Comment 5

[Mike Conley (:mconley) (:⚙️)]

about:addons

• toolkit/themes/shared/extensions/category-themes.svg (themes.svg)
• toolkit/themes/shared/extensions/category-discover.svg (highlights-20.svg)
• toolkit/themes/shared/extensions/category-extensions.svg (extension-fill.svg)

about:preferences

• browser/themes/shared/preferences/category-privacy-security.svg (lock-20.svg)
• browser/themes/shared/preferences/category-general.svg (settings-20.svg)
• browser/themes/shared/preferences/category-sync.svg (sync-20.svg)
• browser/themes/shared/preferences/category-experiments.svg (experiments-20.svg)
• browser/themes/shared/preferences/category-search.svg (search-20.svg)

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1706935 - Update about:addons and about:preferences pane selector icons. r?sfoster!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd857d5a6fb0
Update about:addons and about:preferences pane selector icons. r=preferences-reviewers,jaws

Comment 8

[Atila Butkovits]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/a589d46e82266abac6ad3bfbda4b2fea17a39709

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=bZWBHkfeQ_GRoyb8LQBOzg.0&revision=dd857d5a6fb07679a066c6b673677edca31e92ef&searchStr=linux%2Cx64%2Ctsan%2Cbuild-linux64-tsan%2Fopt%2Cbo

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337896666&repo=autoland&lineNumber=77871

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d20682560678
Update about:addons and about:preferences pane selector icons. r=preferences-reviewers,jaws

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d20682560678

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9218729 [details]
Bug 1706935 - Update about:addons and about:preferences pane selector icons. r?sfoster!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Asset swap for new Proton icons.
• String changes made/needed: None.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/678d9faead8e

Comment 13

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 90.a1(20210519083222) and 89.0b14(20210518190425) on Ubuntu 20, Win10x64 and macOS11.