1706939 - svg use elements referring to def elements scaled incorrectly when printing

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[hsc]

Attachment: arrangement.svg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.85 Safari/537.36

Steps to reproduce:

Opened the attached svg file, the arrangement looks as expected.

Actual results:

Upon view of the printing preview and the actual print the USE references elements to DEF elements of the svg are incorrectly scaled (maybe also positioned, hard to see). It looks like the scaling information imposed by the viewbox are ignored while printing, but correctly used in the display, when not printing

Expected results:

The SVG USE elements should be scaled in line with the other components when printing

Comment 1

[hsc]

Attachment: Print Preview

This shows the printing preview and the incorrectly scaled def elements

Comment 2

[hsc]

Attachment: View in the Browser (without printing)

This is the inital view where the scaling is done correctly

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Printing' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Simpler test-case.

Robert, do you happen to know where are these attributes hooked into rendering off the top of your head by any chance?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Ah, found it. SVGViewportElement::GetViewBoxTransform is indeed returning wrong values in the print document, somehow.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

this code is not running for the print clone.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1706939 - Copy internal attribute values from SVG elements for printing. r=longsonr,#layout-reviewers

This ensures that the clone that printing does doesn't lose track of
them.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1706939 - Make the SVG attribute code a bit more generic. r=longsonr,#layout-reviewers

This could still be massively improved... Why the heck are we doing so
many virtual calls to parse an attribute? :(

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62fcb8d1c124
Make the SVG attribute code a bit more generic. r=longsonr
https://hg.mozilla.org/integration/autoland/rev/a470837de091
Copy internal attribute values from SVG elements for printing. r=longsonr

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28673 for changes under testing/web-platform/tests

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/62fcb8d1c124
https://hg.mozilla.org/mozilla-central/rev/a470837de091

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot