Closed Bug 1706961 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 28641 - [navigation] Simplify <object> fallback handling

Categories

(Core :: Performance: General, task, P4)

Product:
Core
Component:
Performance: General
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28641 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28641
Details from upstream follow.

b'Daniel Cheng <dcheng@chromium.org>' wrote:

[navigation] Simplify <object> fallback handling

If a navigation in an \<object> frame will result in a network or HTTP
error, simply inform parent frame to render fallback content instead of
asking the \<object> frame to commit a navigation, only for the commit to
be ignored when Blink realizes it should trigger the fallback content for
\<object>.

Change-Id: I0c5a3889d3aeaad25cdc6190d5bda0a76f5e6a9a
Reviewed-on: https://chromium-review.googlesource.com/2638444
WPT-Export-Revision: baba228d514e94e6d644da41fb4a8168a96cf763

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 12
PASS : 41
FAIL : 9

Chrome

OK : 10
PASS : 39
FAIL : 1
TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/element-timing/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS)
/largest-contentful-paint/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS)
/resource-timing/crossorigin-sandwich-no-TAO.sub.html
startTime == fetchStart in cross-origin redirect with failing Timing-Allow-Origin.: FAIL (Chrome: PASS)
/resource-timing/crossorigin-sandwich-partial-TAO.sub.html
redirectStart == 0 in cross-origin redirect with failing Timing-Allow-Origin.: FAIL (Chrome: PASS)
redirectEnd == 0 in cross-origin redirect with failing Timing-Allow-Origin.: FAIL (Chrome: PASS)
startTime == fetchStart in cross-origin redirect with failing Timing-Allow-Origin.: FAIL (Chrome: PASS)
/resource-timing/object-not-found-after-cross-origin-redirect.html
startTime == fetchStart in cross-origin redirect.: FAIL
/resource-timing/resource_timing_cross_origin_redirect_chain.html
startTime == fetchStart in cross-origin redirect.: FAIL (Chrome: PASS)
/resource-timing/tao-star-SO-XO-SO-redirect-chain.https.html
Verify that cross origin resources' timings are exposed when cross-origin redirects have Timing-Allow-Origin: * headers: FAIL (Chrome: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46eb073c6dcf [wpt PR 28641] - [navigation] Simplify <object> fallback handling, a=testonly https://hg.mozilla.org/integration/autoland/rev/ac1964eb8793 [wpt PR 28641] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/46eb073c6dcf
https://hg.mozilla.org/mozilla-central/rev/ac1964eb8793

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.