1706970 - [macOS, nightly only] Bookmark popups in the bookmarks toolbar open when using ctrl-click to bring up the context menu

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P5)

Description

[Romain Testard [:RT]]

Attachment: mac_pop.png

This seems to be a macOS only issue reported to me where I cannot reproduce on Win10.

Comment 1

[:Gijs (he/him)]

Meridel, can you clarify how to reproduce the screenshot in comment #0?

The (empty) thing is a menupopup indicating the folder has nothing in it. It's not a tooltip. It would normally appear when the folder is opened, because otherwise clicking a folder would do nothing, which would confuse users. I can't reproduce the screenshot - if I open the folder first, it is closed when I try to rename it; if I create or rename a folder that is not open, it does not open and I cannot open it because of the modal overlay that prevents me interacting with the window.

Comment 2

[Meridel [:meridel]]

Steps to reproduce on Nightly using MacOS:

1. Create a new bookmark folder on the toolbar
2. Right-click the empty folder and select "Rename folder"
3. Folder re-name modal opens but it is overlayed with the message: (Empty)

I don't think the message is providing much value, and is more annoying than anything. Could we/should we suppress it?

Comment 3

[:Gijs (he/him)]

(In reply to Meridel [:meridel] from comment #2)

Steps to reproduce on Nightly using MacOS:

1. Create a new bookmark folder on the toolbar
2. Right-click the empty folder and select "Rename folder"
3. Folder re-name modal opens but it is overlayed with the message: (Empty)

I can only reproduce on macOS, and only if I use ctrl+click to "right click". If I use the touchpad or a mouse to right click without using ctrl, the menu doesn't open. This means this is yet more fallout from bug 1615732, which isn't turned on for beta/release so marking those as unaffected.

I don't think the message is providing much value, and is more annoying than anything. Could we/should we suppress it?

The menu definitely shouldn't open when you right-click (and it doesn't on beta/release, including 89). We can keep this bug open to fix that.

I'm not sure if you are also critiquing the use of the "(empty)" message for empty folders (ie are you also saying that shouldn't come up when you left click the item?). If so, we have bug 1705339 for that where your feedback would be appreciated. AIUI it's there both to provide feedback to the user (as opposed to doing nothing when clicking the item) and to ensure users can drag/drop items into the popup (ie to have a target on which to drop things). We could replace it with something more playful ("(Nothing here yet!)" or any other string) if desired. We can discuss more in that bug if you like.

Romain: I'd like to de-prioritize this both in JIRA and on bmo given that this is macOS-only and restricted to nightly (so 89 release is not affected). Does that make sense?

Comment 4

[Romain Testard [:RT]]

I did not realize that this was not going to impact release, agreed, moving to a P5

Comment 5

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: overlap.png

Hi,

I can also reproduce in beta 89.0b11 (64-bit).
Best,

Clara.

Comment 6

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: overlapping.mov

Comment 7

[:Gijs (he/him)]

(In reply to Clara Guerrero from comment #5)

Created attachment 9221784 [details]
overlap.png

Hi,

I can also reproduce in beta 89.0b11 (64-bit).
Best,

Clara.

This appears to happen if you right click the (Empty) bit - from the steps in comment #2 I assumed we were clicking the actual folder itself.

This particular version of the bug (ie using only the trackpad (without ctrl) to open the context menu when the bookmark folder dropdown is already open) should be fixed by the changes in bug 1705120, which have landed on nightly but have not yet been uplifted. Can you confirm?

Comment 8

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Yes, I confirm that the version of the bug shown in my video is not reproducible in latest nightly build 90.0a1 (2021-05-13) (64-bit).

Thanks!

Comment 9

[Edgar Chen [:edgar]]

I could not reproduce this on recent Nightly. I got following result on mozregression with --find-fix,

54:39.33 INFO: First good revision: 130f10069b563f3af555c810823cf52a62314854
54:39.33 INFO: Last bad revision: 79a1b53dcccd4ccedf394f201b31720cb094b8f8
54:39.33 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=79a1b53dcccd4ccedf394f201b31720cb094b8f8&tochange=130f10069b563f3af555c810823cf52a62314854

it seems Bug 1703518 also fix this.

Romain, are you still seeing this issue on recent Nightly?

Comment 10

[Romain Testard [:RT]]

I reported on behalf of Meridel, Meridel can you please confirm?

Comment 11

[Meridel [:meridel]]

Attachment: New empty message for empty bookmarks folder.png

I followed my steps to reproduce and the issue appears to be resolved. I no longer see the floating "Empty" message above. When the folder is empty, and I right-click, I now get this "Empty" message.

Comment 12

[:Gijs (he/him)]

OK, let's resolve wfm based on the comments. Thanks!