The attached URL crashes Mozilla (tested Win2k and RH72). It inserts a new style rule in an existing media rule and then queries for the parent rule of the style rule. Expected result : the media rule Actual result : crack boom core dump (Nota bene : this blocks CaScadeS)
Created attachment 100543 [details] [diff] [review] patch I chose this fix rather than changing SetParentRuleReference because I'm worried that some compilers might do an adjustment on the null by mistake. (I recall CodeWarrior doing it when constant-folding -- someone wrote a null-based table-driven QI that worked on CodeWarrior, but I'm not sure if it would do the same thing at runtime.)
Comment on attachment 100543 [details] [diff] [review] patch r=glazman
Comment on attachment 100543 [details] [diff] [review] patch sr=roc+moz
Fix checked in to trunk, 2002-10-02 18:02 PDT.
checked the testcase mentioned in the url on win2000 -------- 2002-10-03-08trunk RH linux7.2 ---- 2002-10-03-08trunk there is no crash. Marking verified.
The testcase is still crashing the win2k branch build. I checked on the 2002-10-28-12-1.0 branch build on win2000. The trunk build looks good. What are the plans for this patch to be checked in branch ???
It's simple enough that we might as well... I've requested driver approval.
that would be great . Thanks Boris!!
adt would take this on the branch if drivers approve. Please add the fixed1.0.2 keyword if it gets checked in.
removing adt markings, please renominate if you get drivers approval.