[CRASH] CSSRule.parentRule crashes on a style rule inserted in a media rule

VERIFIED FIXED in mozilla1.2beta

Status

()

Core
CSS Parsing and Computation
P2
major
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: glazou, Assigned: dbaron)

Tracking

({testcase})

Trunk
mozilla1.2beta
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch], URL)

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
The attached URL crashes Mozilla (tested Win2k and RH72).

It inserts a new style rule in an existing media rule and then queries for the
parent rule of the style rule.

Expected result : the media rule
Actual result   : crack boom core dump

(Nota bene : this blocks CaScadeS)
(Assignee)

Comment 1

15 years ago
Created attachment 100543 [details] [diff] [review]
patch

I chose this fix rather than changing SetParentRuleReference because I'm
worried that some compilers might do an adjustment on the null by mistake.  (I
recall CodeWarrior doing it when constant-folding -- someone wrote a null-based
table-driven QI that worked on CodeWarrior, but I'm not sure if it would do the
same thing at runtime.)
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.2beta
(Assignee)

Updated

15 years ago
Whiteboard: [patch]
(Reporter)

Comment 2

15 years ago
Comment on attachment 100543 [details] [diff] [review]
patch

r=glazman
Attachment #100543 - Flags: review+
Comment on attachment 100543 [details] [diff] [review]
patch

sr=roc+moz
Attachment #100543 - Flags: superreview+

Updated

15 years ago
Keywords: testcase
(Assignee)

Comment 4

15 years ago
Fix checked in to trunk, 2002-10-02 18:02 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 5

15 years ago
checked the testcase mentioned in the url on 
win2000 -------- 2002-10-03-08trunk
RH linux7.2 ---- 2002-10-03-08trunk

there is no crash. Marking verified.


Status: RESOLVED → VERIFIED

Comment 6

15 years ago
--> nsbeta1
Keywords: nsbeta1

Comment 7

15 years ago
The testcase is still crashing the win2k branch build. I checked on the
2002-10-28-12-1.0 branch build on win2000. 

The trunk build looks good. What are the plans for this patch to be checked in
branch ??? 

It's simple enough that we might as well... I've requested driver approval.

Comment 9

15 years ago
that would be great .

Thanks Boris!!
adt would take this on the branch if drivers approve. Please add the fixed1.0.2
keyword if it gets checked in.
Keywords: adt1.0.2+

Comment 11

15 years ago
removing adt markings, please renominate if you get drivers approval.
Keywords: adt1.0.2+
You need to log in before you can comment on or make changes to this bug.