Return to having `NSDISTMODE=copy` impact `INSTALL`
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
This ticket tracks reverting part of Bug 1255485.
It should have been reverted in Bug 1641291, which allowed NSDISTMODE=copy to impact build manifests. This is useful when cross-compiling: this stops some symlinks within the object directory itself, say from dist/include to an object subdirectory.
|
Assignee | |
Comment 1•3 years ago
|
||
My specific use case right now is making the clang preprocessor behave the same way across build host machines. clang is clever and unifies symlinked files (in many/most cases). Those unified files will have a C header guard optimization applied regardless of which file is included, and they will be "skipped" rather than "entered" and "exited". This leads to subtly different preprocessor behaviour on Windows build hosts, which manifests as extra blank lines in the preprocessed output.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This reverts part of Bug
1255485.
It should have been reverted in Bug 1641291, which allowed
NSDISTMODE=copy to impact build manifests. This is useful when
cross-compiling: this stops some symlinks within the object directory
itself, say from dist/include to an object directory.
|
||
Updated•3 years ago
|
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3aa883d4b622 Return to having NSDISTMODE=copy impact INSTALL. r=firefox-build-system-reviewers,mhentges
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•