Remove invalid assert in AnimationFrameRecyclingQueue::RecycleFrame
Categories
(Core :: Graphics: ImageLib, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The following assert:
MOZ_ASSERT(mFirstFrameRefreshArea.Contains(entry.mDirtyRect));
is likely not true, because entries might have the full rect area used temporarily:
and it doesn't get reset until the animation is complete:
which probably happens before the assert in question happens. So some frames might be marked with a dirty area larger than necessary out of caution. When the animation has its first pass, we shrink that area, which means it is no longer guaranteed to contain the conservative dirty area estimates we made earlier.
|
Assignee | |
Comment 1•4 years ago
|
||
The assert in question is overly conservative. The dirty rects may be
calculated using a more conservative estimate of the whole frame, and
after the animation has completed its first pass, we may have determined
that it is unnecessarily too large and shrink it accordingly. There may
still be frames lingering with the old larger rect however, and trip
this assert falsely.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•