1707053 - Use Secondary text color for action text in Light theme

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Harry Twyford]

We already use Secondary text for action text in Dark theme. Amy says we should do the same for light theme.

Comment 1

[Harry Twyford]

Attachment: Bug 1707053 - Use Secondary text color for action text in Light theme. r?mak,dao

Comment 2

[Harry Twyford]

[Tracking Requested - why for this release]:

Required for Proton/MR1. It's an easy uplift as it's just a minor color change.

I'll request uplift tomorrow after I verify the fix in Nightly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9434ddcd9ee
Use Secondary text color for action text in Light theme. r=dao

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_ext_themes_autocomplete_popup.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/40604f517585b830671a9c0876ac42029c432c7d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=K4_fq8YJTVOI5ir-w3bpwQ.0&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc10&revision=b9434ddcd9ee75c669ac8fb574de7430e03c1fd1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337890037&repo=autoland&lineNumber=2280

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee60a2b0aab7
Use Secondary text color for action text in Light theme. r=dao

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ee60a2b0aab7

Comment 7

[Harry Twyford]

Comment on attachment 9217846 [details]
Bug 1707053 - Use Secondary text color for action text in Light theme. r?mak,dao

Beta/Release Uplift Approval Request

• User impact if declined: Proton color inconsistency in the address bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changes some color values in CSS and theme manifests. No behavioural changes.
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9217846 [details]
Bug 1707053 - Use Secondary text color for action text in Light theme. r?mak,dao

Approved for 89 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a9edb42dfa6